Skip to content

fixed bug with dimple height being incorrect #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaikoHermans wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixed bug with dimple height being incorrect #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e3b8fe
added if statement on height. Dimple was to high when interItemSpacin…
MaikoHermans Feb 25, 2016
81664cb
fix for when interItemSpacingY holds a - value
MaikoHermans Feb 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion RBCollectionViewInfoFolderLayout/RBCollectionViewInfoFolderLayout.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,12 @@ - (UICollectionViewLayoutAttributes *)layoutAttributesForSupplementaryViewOfKind
CGFloat deltaX = [self.deltaXInSection[@( indexPath.section )] floatValue];

CGFloat additionalHeight = 10;
CGFloat height = self.interItemSpacingY + additionalHeight;
CGFloat height = self.interItemSpacingY + additionalHeight;;

if(height <= 10){
height = additionalHeight * 2;
}
Copy link
Owner

@eoghain eoghain Feb 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should match existing file indenting and code style (i.e. tab indentation, curly braces on new lines aligned with start of block, etc.). This is just good practice when working in someone elses code base.

Copy link
Author

@MaikoHermans MaikoHermans Feb 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that it did that. When I edited it it was the same code style. Thanks for telling me tho next time I'll be sure to take a better look at it. Also after some more testing with it it seems that this bug occurred because of the way I set up my layout


CGFloat width = (height / 3) * 5;

if (cellsPerRowInSection == 1)
Expand Down