contracts-bedrock: port custom gas token to portal2

[tynes]

Description

Ports the custom gas token feature to OptimismPortal2.
This will enable fault proofs to run on custom gas token
chains.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.44%. Comparing base (822df50) to head (3d2d8dd).
Report is 7 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (822df50) and HEAD (3d2d8dd). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (822df50)	HEAD (3d2d8dd)
cannon-go-tests	1	0

Additional details and impacted files

@@             Coverage Diff              @@
##           develop   #10780       +/-   ##
============================================
- Coverage    60.69%   16.44%   -44.25%     
============================================
  Files           20        8       -12     
  Lines         1781      535     -1246     
  Branches        71       71               
============================================
- Hits          1081       88      -993     
+ Misses         667      447      -220     
+ Partials        33        0       -33     

Flag	Coverage Δ
cannon-go-tests	?
chain-mon-tests	27.14% <ø> (ø)
sdk-tests	16.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

[tynes]

@coderabbitai summary

[tynes]

@coderabbitai Double check that all of the tests from OptimismPortal.t.sol involving custom gas token have been ported to OptimismPortal2.t.sol

[tynes]

@mds1 - I went through and made sure all of the tests were ported from the original implementation

[mds1]

This looks great, seems like the merge was pretty straightforward as expected.

I assume in a follow up PRs we will delete the original portal then rename portal2 to portal?

I went through and made sure all of the tests were ported from the original implementation

Unfortunately I did not get a chance to double check this, but would just ask if we can get someone else to verify none are missing before merge. Worst case I can confirm once I'm back from vacation

[tynes]

I assume in a follow up PRs we will delete the original portal then rename portal2 to portal?

Yup, exactly!

Unfortunately I did not get a chance to double check this, but would just ask if we can get someone else to verify none are missing before merge. Worst case I can confirm once I'm back from vacation

Nobody has taken the time to do this review yet, so this is still pending. No major rush, this is nice to have to enable the interop devnet to run with the fault proof code, will rebase #11051 on top of this after its merged on develop

[tynes]

@mds1 There has been no progress on this PR while you have been on vacation, but I did go through myself to double check that all the tests were ported and didn't find anything missing

[semgrep-app]

Semgrep found 2 todos_require_linear findings:

• packages/devnet-tasks/src/tasks/deposit-eth.ts
  • L415 - Triage
• packages/devnet-tasks/src/tasks/deposit-erc20.ts
  • L355 - Triage

Please create a GitHub ticket for this TODO.

_{Ignore this finding from todos_require_linear.}

[tynes]

@mds1 bump on this, I know you are busy but I do think this is good to merge. It will unblock me from doing another custom gas token release

[mds1]

There has been no progress on this PR while you have been on vacation, but I did go through myself to double check that all the tests were ported and didn't find anything missing

Thanks, I also confirmed with a regex search of \bfunction\s+test.*Gas.*\b to find all gas related tests in OptimismPortal.t.sol and confirm it matches the set in OptimismPortal2.t.sol, which it did

Since no other changes have been made since my last review, this LGTM. Nice work, it's great to have these merged