add-chain: fix issues found via binary walkthrough #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwiseguy
commented
Jul 29, 2024
bitwiseguy
requested review from
geoknee and
sebastianst
and removed request for
geoknee
sebastianst
reviewed
Jul 30, 2024
sebastianst
approved these changes
Jul 31, 2024
bitwiseguy
force-pushed
the
ss/fix-add-chain-bugs
branch
from
a996858 to
f1bf98b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the following bugs:
.deploySCR_CHAIN_NAMEin quotes to support names with spacesAdditional changes
Added a test for legacy deployment files (one .json file for each contract instead of a single .deploy file). Previously this was untested code