Skip to content
This repository was archived by the owner on Jan 23, 2024. It is now read-only.

update build tools, fabric, and okhttp#789

Merged
nahojjjen merged 1 commit intofarkam135:masterfrom
harkin:hl/update-dependencies
Oct 16, 2017
Merged

update build tools, fabric, and okhttp#789
nahojjjen merged 1 commit intofarkam135:masterfrom
harkin:hl/update-dependencies

Conversation

@harkin
Copy link
Contributor

@harkin harkin commented Oct 14, 2017

No description provided.

apt 'com.jakewharton:butterknife-compiler:8.4.0'
apt 'org.projectlombok:lombok:1.16.10'
onlineCompile 'com.squareup.okhttp3:okhttp:3.4.1'
onlineCompile 'com.squareup.okio:okio:1.10.0'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okio is a transitive dependency of okhttp so specifying it here doesn't achieve much

@harkin harkin force-pushed the hl/update-dependencies branch 3 times, most recently from 189482e to 3321ccc Compare October 14, 2017 19:13
@MARTINI1
Copy link
Contributor

MARTINI1 commented Oct 16, 2017

in this PR travis use build tools 26.0.2 but then in PR #790 it is changed to 26.0.1, it also happens in buildToolsVersion that in one PR is updated but then it goes back to 25.0.0

please fix these changes

@harkin
Copy link
Contributor Author

harkin commented Oct 16, 2017

@MARTINI1 Not sure what you mean. This PR updates the android build tools to 26.0.2, the latest version (release notes). My other PR updates the android platform tools to 26.0.1, the latest version (release notes)

They are independent, atomic changes. Neither PR is resetting something done in the other. What needs fixing?

@MARTINI1
Copy link
Contributor

you're right, I was confused when I looked at the lines of build-tools and platform-tools...

now only remains @nahojjjen merge this PR, #790 and the #792

sorry for the confusion

@nahojjjen nahojjjen merged commit fbe9571 into farkam135:master Oct 16, 2017
@nahojjjen
Copy link
Collaborator

Looks good 👍

@harkin harkin deleted the hl/update-dependencies branch October 16, 2017 14:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants