update build to target oreo and use version 26 of support libs#790
update build to target oreo and use version 26 of support libs#790nahojjjen merged 2 commits intofarkam135:masterfrom
Conversation
| compile 'com.android.support:appcompat-v7:26.1.0' | ||
| compile 'com.android.support:preference-v7:26.1.0' | ||
| compile 'com.android.support:recyclerview-v7:26.1.0' | ||
| compile 'com.android.support:design:26.1.0' |
There was a problem hiding this comment.
preference-v7 and design are transitive dependencies currently.
com.pavelsikun:material-seekbar-preference uses an old version of preferences and io.apptik.widget:multislider uses an old version of design.
There's an error in Android Studio warning that using support libraries from different versions could lead to crashes. By including them all libraries use the latest versions. I've tested both seekbars and they work properly on my device
harkin
force-pushed
the
hl/update-target-version
branch
from
2661dd8 to
f649166
Compare
harkin
force-pushed
the
hl/update-target-version
branch
from
f649166 to
8aa8d29
Compare
openCVLibrary330/build.gradle
Outdated
| android { | ||
| compileSdkVersion 24 | ||
| compileSdkVersion 26 | ||
| buildToolsVersion "25.0.0" |
There was a problem hiding this comment.
Should you also update build tools to 26.0.2?
There was a problem hiding this comment.
I have a separate PR for upgrading the build tools here, upgrading the build tools and dependencies is a safe and non controversial action.
I thought moving to target Oreo might be more controversial so I split it out.
Ideally both get merged, but it's not a complete necessity to merge them simultaneously
|
@nahojjjen as soon as @harkin reviews my comment abount build-tools 26.0.2 could you merge this? |
|
Hey, thanks for the PR! This pr got into conflict after I merged your other PR, #789, so I used githubs "fix conflict" feature to try and fix it. It's good that you split up the PRs like this, its just that I feel bad when I make your PRs messier with my merge commits. If you know a better way of doing it, or if I made a mistake, please tell me. |
|
I find githubs feature is kinda messy. Does github have the option to rebase? I find rebasing to be the cleanest solution |
|
Yes, I should have probably rebased, or asked you to rebase. Sorry. |
|
no worries! |
3 participants
No description provided.