N-06 add missing named parameters in mappings #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses N-06 from the Q3 2025 OZ audit Since Solidity 0.8.18, mappings can include named parameters to provide more clarity about their purpose. Named parameters allow mappings to be declared in the form mapping(KeyType KeyName? => ValueType ValueName?). This feature enhances code readability and maintainability. Throughout the codebase, multiple instances of mappings without named parameters were identified: The approvedWorkloads state variable in the BlockBuilderPolicy contract. The nonces state variable in the BlockBuilderPolicy contract. The registeredTEEs state variable in the FlashtestationRegistry contract. The nonces state variable in the FlashtestationRegistry contract. The cachedWorkloads state variable in the BlockBuilderPolicy contract. Consider adding named parameters to mappings in order to improve the readability and maintainability of the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses N-06 from the Q3 2025 OZ audit
Since Solidity 0.8.18, mappings can include named parameters to provide more clarity about their purpose. Named parameters allow mappings to be declared in the form mapping(KeyType KeyName? => ValueType ValueName?). This feature enhances code readability and maintainability.
Throughout the codebase, multiple instances of mappings without named parameters were identified:
The approvedWorkloads state variable in the BlockBuilderPolicy contract. The nonces state variable in the BlockBuilderPolicy contract. The registeredTEEs state variable in the FlashtestationRegistry contract. The nonces state variable in the FlashtestationRegistry contract. The cachedWorkloads state variable in the BlockBuilderPolicy contract. Consider adding named parameters to mappings in order to improve the readability and maintainability of the codebase.