Skip to content

N-06 add missing named parameters in mappings #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Melvillian merged 1 commit into from
Aug 20, 2025
Merged

N-06 add missing named parameters in mappings #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/BlockBuilderPolicy.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,17 @@ contract BlockBuilderPolicy is
/// Adding and removing a workload is O(1).
/// This means the critical `_cachedIsAllowedPolicy` function is O(1) since we can directly check if a workloadId exists
/// in the mapping
mapping(bytes32 => WorkloadMetadata) private approvedWorkloads;
mapping(bytes32 workloadId => WorkloadMetadata) private approvedWorkloads;

/// @inheritdoc IBlockBuilderPolicy
address public registry;

/// @inheritdoc IBlockBuilderPolicy
mapping(address => uint256) public nonces;
mapping(address teeAddress => uint256 permitNonce) public nonces;

/// @notice Cache of computed workloadIds to avoid expensive recomputation
/// @dev Maps teeAddress to cached workload information for gas optimization
mapping(address => CachedWorkload) private cachedWorkloads;
mapping(address teeAddress => CachedWorkload) private cachedWorkloads;

/// @dev Storage gap to allow for future storage variable additions in upgrades
/// @dev This reserves 46 storage slots (out of 50 total - 4 used for approvedWorkloads, registry, nonces, and cachedWorkloads)
Expand Down
4 changes: 2 additions & 2 deletions src/FlashtestationRegistry.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@ contract FlashtestationRegistry is
* @notice Returns the registered TEE for a given address
* @dev This is used to get the registered TEE for a given address
*/
mapping(address => RegisteredTEE) public registeredTEEs;
mapping(address teeAddress => RegisteredTEE) public registeredTEEs;

/// @inheritdoc IFlashtestationRegistry
mapping(address => uint256) public override nonces;
mapping(address teeAddress => uint256 permitNonce) public override nonces;

/// @dev Storage gap to allow for future storage variable additions in upgrades
/// @dev This reserves 47 storage slots (out of 50 total - 3 used for attestationContract, registeredTEEs and nonces)
Expand Down