fix(handlers): cleanup after container has run #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doanac
reviewed
Apr 11, 2025
| ) | ||
|
|
||
| cmd = ["docker", "run"] | ||
| cmd = ["docker", "run", "--rm"] |
Member
There was a problem hiding this comment.
with this, I think we can remove the docker_clean logic
Also - the commit message should explain the why and subject can drop the improvement line.
Member
Author
There was a problem hiding this comment.
Improved the commit message and the title. I think we can remove the docker_clean logic too, as what I have seen is that the other directories inside docker did not contribute much to the disk space used.
StealthyCoder
changed the title
This simple addition to running `docker` will make it so the containers upon exit will clean up files left on the disk. In particular the files in the `overlay2` directory. This will help improve robustness concerning workers getting jobs and running out of disk space. This compliments the efforts within this PR foundriesio#143. Signed-off-by: Eric Bode <eric.bode@foundries.io>
StealthyCoder
changed the title
StealthyCoder
force-pushed
the
improvement/docker_run_rm
branch
from
26d9def to
5403468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the correct place to add the
--rmoption to clean up after the docker containers we run have executed.