Skip to content

fix(handlers): cleanup after container has run #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StealthyCoder wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(handlers): cleanup after container has run #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion runner/jobserv_runner/handlers/simple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def hung_cb():
stderr=f,
)

cmd = ["docker", "run"]
cmd = ["docker", "run", "--rm"]
Copy link
Member

@doanac doanac Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this, I think we can remove the docker_clean logic

Also - the commit message should explain the why and subject can drop the improvement line.

Copy link
Member Author

@StealthyCoder StealthyCoder Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved the commit message and the title. I think we can remove the docker_clean logic too, as what I have seen is that the other directories inside docker did not contribute much to the disk space used.

cmd.extend(["--name", name])
cmd.extend(["-w", self.container_cwd])
cmd.extend(["--env-file", env_file])
Expand Down