fix: Stop autoconnect thread on quit #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix autoconnect thread never exiting on quit
Contributor
Author
|
Noticed this when enabling autoconnect + latency, and then clicking my "Exit" button in game. The process will stall out until OS crashes it. |
elementbound
changed the title
Contributor
|
Thanks a lot for the report and the fix @quicksnap! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code waits to finish, but thread will never quit.
Tested locally, but I just kinda whipped this together. Feel free to close and fix to your liking if you prefer!
Thanks so much for making Netfox!