Skip to content

Conversation

@guerler
Copy link
Contributor

@guerler guerler commented Oct 16, 2025

Requires #21264. This PR removes the legacy report application, see discussion in #21010.

This PR removes several remaining legacy components and frameworks:

  1. The global bundleEntries client bundle has been removed.
  2. The Mako templates directory of the Galaxy app has been cleared (61 Mako files deleted, 3 remaining).
  3. The legacy grid backend and client modules have been removed from the Galaxy app.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Oct 16, 2025
@guerler guerler force-pushed the remove_reports_app branch 2 times, most recently from c45cc2f to e77d92c Compare December 1, 2025 08:30
@guerler guerler changed the title [WIP] Remove reports app Remove Reports app Dec 1, 2025
@guerler guerler changed the title Remove Reports app Remove Reports Application Dec 1, 2025
@guerler guerler force-pushed the remove_reports_app branch 7 times, most recently from 7aa9176 to 18d4e58 Compare December 2, 2025 10:49
@guerler guerler marked this pull request as ready for review December 2, 2025 13:57
@github-actions github-actions bot added this to the 26.0 milestone Dec 2, 2025
@guerler guerler force-pushed the remove_reports_app branch from 18d4e58 to cfe7f25 Compare December 2, 2025 16:27
@bgruening
Copy link
Member

I think it's time to let the reports webapp go. Thanks a lot @guerler for working on it.

Deprecation notice is in 25.1 https://github.com/galaxyproject/galaxy/pull/21162/files#r2582108674

@bgruening
Copy link
Member

How is the old TS deployed at the moment? Do we need to take some extra care here to not destroy the older deployment of the old TS?

@guerler
Copy link
Contributor Author

guerler commented Dec 3, 2025

@bgruening This does not affect the Toolshed 1.0 deployment. That work was already separated in #15000

@bgruening
Copy link
Member

Thanks for checking @guerler

@guerler guerler requested a review from itisAliRH December 3, 2025 12:43
Copy link
Member

@itisAliRH itisAliRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @guerler!

@guerler guerler merged commit 2a5538b into galaxyproject:dev Dec 3, 2025
63 of 67 checks passed
@guerler guerler deleted the remove_reports_app branch December 3, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/reports area/testing/selenium area/testing area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants