feat(ui): add settings dropdown to sidebar profile#365
feat(ui): add settings dropdown to sidebar profile#365itshae43 wants to merge 4 commits intogetnao:mainfrom
Conversation
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/frontend/src/components/sidebar-user-menu.tsx">
<violation number="1" location="apps/frontend/src/components/sidebar-user-menu.tsx:85">
P1: Bug: `signOut()` is called without clearing the React Query cache or handling the redirect. The existing logout in `_sidebar-layout.settings.general.tsx` properly calls `queryClient.clear()` and passes `fetchOptions.onSuccess` to navigate to the login page. This bare `signOut()` call will leave stale user data in cache and may not redirect the user reliably.
Consider extracting the existing `handleSignOut` logic into a shared hook/utility and reusing it here.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
Hi @itshae43 , thanks for the PR ! We have to talk in intern about the icons and what to put in this dropdown menu... We will come back later on it 👍🏻 |
|
Hey @itshae43 thank you for this. Here my feedback, I think the menu needs to be simplified:
Also we will not do the followup that you're proposing I think icons are adding too much visual noise. |
dbdba0b to
474c69c
Compare
04da7ef to
9736fc5
Compare
|
Hey @itshae43, would it be possible to remove the border in the dropdown between Settings and Memory+Project. Don't forget that Settings entry should also be clickable and open the general page. also the border in the sidebar, would be great if it fits the whole width |




Why
Previously, clicking the profile area navigated directly to
/settings/general.Users had no way to jump to Memory, Project, or Usage & Cost without landing on General first and then navigating.
Testing
npm run lintpassesNext
To make more polished needs additional code changes.
I’ll address this in a separate PR.
@Bl3f
Please review this and add comments where needed to guide me in the right direction.
(https://www.figma.com/design/4Q0ljxsbfAtc3PUw1H3lmI/Nao-Labs?node-id=64-872&t=q3Q76kUoFRTUGUBd-1)
UI Change In Figma File (Experiments)