Skip to content

feat(ui): add settings dropdown to sidebar profile#365

Open
itshae43 wants to merge 4 commits intogetnao:mainfrom
itshae43:ui/account-menu-popover
Open

feat(ui): add settings dropdown to sidebar profile#365
itshae43 wants to merge 4 commits intogetnao:mainfrom
itshae43:ui/account-menu-popover

Conversation

@itshae43
Copy link
Contributor

@itshae43 itshae43 commented Feb 26, 2026

Why

Previously, clicking the profile area navigated directly to
/settings/general.

Users had no way to jump to Memory, Project, or Usage & Cost without landing on General first and then navigating.

Light Mode Dark Mode
Before After

Testing

  • Click profile → dropdown opens above button
  • Click General / Memory / Project / Usage & Cost → navigates correctly
  • Click Log Out → session cleared, redirected to login
  • Hover Log Out → turns red
  • Press Escape → dropdown closes
  • Click outside → dropdown closes
  • Collapse sidebar → arrow hidden, dropdown still works
  • npm run lint passes
image

Next

To make more polished needs additional code changes.
I’ll address this in a separate PR.

@Bl3f
Please review this and add comments where needed to guide me in the right direction.
(https://www.figma.com/design/4Q0ljxsbfAtc3PUw1H3lmI/Nao-Labs?node-id=64-872&t=q3Q76kUoFRTUGUBd-1)


UI Change In Figma File (Experiments)

Light Mode Dark Mode

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/frontend/src/components/sidebar-user-menu.tsx">

<violation number="1" location="apps/frontend/src/components/sidebar-user-menu.tsx:85">
P1: Bug: `signOut()` is called without clearing the React Query cache or handling the redirect. The existing logout in `_sidebar-layout.settings.general.tsx` properly calls `queryClient.clear()` and passes `fetchOptions.onSuccess` to navigate to the login page. This bare `signOut()` call will leave stale user data in cache and may not redirect the user reliably.

Consider extracting the existing `handleSignOut` logic into a shared hook/utility and reusing it here.</violation>
</file>

Since this is your first cubic review, here's how it works:

  • cubic automatically reviews your code and comments on bugs and improvements
  • Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
  • Add one-off context when rerunning by tagging @cubic-dev-ai with guidance or docs links (including llms.txt)
  • Ask questions if you need clarification on any suggestion

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@MatLBS
Copy link
Contributor

MatLBS commented Feb 26, 2026

Hi @itshae43 , thanks for the PR !

We have to talk in intern about the icons and what to put in this dropdown menu...

We will come back later on it 👍🏻

@Bl3f Bl3f mentioned this pull request Feb 26, 2026
10 tasks
@Bl3f
Copy link
Contributor

Bl3f commented Feb 26, 2026

Hey @itshae43 thank you for this. Here my feedback, I think the menu needs to be simplified:

  • In the dropdown you can remove the user icon and details (as it's already in the screen it's useless) and remove the logout, we don't want users to logout from here by missclicking
  • Also in the dropdown I'd keep:
    • a "Settings" > which redirect to General
    • a Memory entry
    • a Project entry
    • costs can be removed

Also we will not do the followup that you're proposing I think icons are adding too much visual noise.

@itshae43 itshae43 force-pushed the ui/account-menu-popover branch from dbdba0b to 474c69c Compare February 27, 2026 16:36
@itshae43
Copy link
Contributor Author

Light Mode Dark Mode

Add a divider above the user menu

Light Mode Dark Mode

@itshae43 itshae43 force-pushed the ui/account-menu-popover branch from 04da7ef to 9736fc5 Compare February 27, 2026 20:18
@Bl3f
Copy link
Contributor

Bl3f commented Mar 2, 2026

Hey @itshae43, would it be possible to remove the border in the dropdown between Settings and Memory+Project. Don't forget that Settings entry should also be clickable and open the general page.

also the border in the sidebar, would be great if it fits the whole width

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants