-
-
Notifications
You must be signed in to change notification settings - Fork 227
fix: deliver system breadcrumbs in the main thread on Android #4671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## version6 #4671 +/- ##
===========================================
Coverage ? 73.18%
===========================================
Files ? 480
Lines ? 17422
Branches ? 3437
===========================================
Hits ? 12750
Misses ? 3821
Partials ? 851 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2122303 to
d43ead6
Compare
jamescrosswell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome... the cumulation of a lot of sleuthing. Thanks @jpnurmi !
I guess there's no easy way to test this eh? Would need an integration test presumably. If that's not too painful, we could add one... but fine to merge as is otherwise.
|
The integration test seems finally ok. It took a few rounds to make it pass with all tested configurations. |
1e3421d to
97e36cb
Compare
Sorry for making you go to that effort... hopefully the tests catch some bugs in the future! |
jamescrosswell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - thanks @jpnurmi !
Fixes: #3828
Deliver network and system event (battery) breadcrumbs in the main thread on Android, to avoid calling the C#
beforeBreadcrumbcallback from unmanaged internal Android worker threads, which can result in obscure and hard to debug crashes (#3828 (comment)).Manually tested with
Sentry.Samples.Mauiand the followingbeforeBreadcrumbcallback inMauiProgram.cs:Before
After
Depends on:chore(deps): update Java SDK to v8.24.0 #4667Merge remote-tracking branch 'upstream/main' into version6 #4683