Skip to content

ref: Minor refactoring simplifying replay quality parsing on Android #5305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2025
Merged

ref: Minor refactoring simplifying replay quality parsing on Android #5305

merged 2 commits into from
Oct 29, 2025
+9 −13

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Oct 24, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Minor refactoring simplifying replay quality parsing on Android

💡 Motivation and Context

See https://github.com/getsentry/sentry-react-native/pull/5301/files#r2461084612

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@antonis antonis marked this pull request as ready for review October 24, 2025 15:59
@antonis antonis mentioned this pull request Oct 24, 2025
Merged
10 tasks
@github-actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 472.86 ms 499.33 ms 26.47 ms
Size 17.75 MiB 19.74 MiB 1.99 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2104bb9+dirty 410.71 ms 461.52 ms 50.81 ms
000da7a 454.46 ms 445.00 ms -9.46 ms
5ee3314+dirty 415.80 ms 426.14 ms 10.34 ms
bfe454a+dirty 573.44 ms 579.46 ms 6.02 ms
d1fd647+dirty 413.02 ms 459.72 ms 46.70 ms
c9e95bd 428.04 ms 458.70 ms 30.65 ms
8ece263 441.96 ms 444.96 ms 3.00 ms
818a608 495.84 ms 498.08 ms 2.25 ms
eb07ba3 470.04 ms 473.35 ms 3.31 ms
69602ce 417.47 ms 443.52 ms 26.05 ms

App size

Revision Plain With Sentry Diff
2104bb9+dirty 17.75 MiB 19.74 MiB 1.99 MiB
000da7a 17.75 MiB 19.68 MiB 1.94 MiB
5ee3314+dirty 17.75 MiB 19.70 MiB 1.95 MiB
bfe454a+dirty 17.75 MiB 19.69 MiB 1.94 MiB
d1fd647+dirty 17.75 MiB 19.70 MiB 1.95 MiB
c9e95bd 17.75 MiB 19.68 MiB 1.93 MiB
8ece263 17.75 MiB 19.68 MiB 1.94 MiB
818a608 17.75 MiB 19.68 MiB 1.94 MiB
eb07ba3 17.75 MiB 20.15 MiB 2.41 MiB
69602ce 17.75 MiB 19.68 MiB 1.94 MiB

@github-actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 327.60 ms 389.00 ms 61.40 ms
Size 7.15 MiB 8.46 MiB 1.30 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2104bb9+dirty 313.00 ms 309.76 ms -3.24 ms
5ee3314+dirty 358.69 ms 394.00 ms 35.31 ms
bfe454a+dirty 372.42 ms 424.52 ms 52.10 ms
d1fd647+dirty 374.46 ms 409.51 ms 35.05 ms
6a70a7e+dirty 382.45 ms 424.54 ms 42.09 ms
276d348+dirty 356.30 ms 405.27 ms 48.97 ms
083f560+dirty 383.96 ms 417.76 ms 33.80 ms
2adbd1e+dirty 366.13 ms 419.49 ms 53.36 ms
49ef936+dirty 333.72 ms 387.51 ms 53.79 ms
8d89cc9+dirty 357.69 ms 415.79 ms 58.10 ms

App size

Revision Plain With Sentry Diff
2104bb9+dirty 7.15 MiB 8.46 MiB 1.30 MiB
5ee3314+dirty 7.15 MiB 8.43 MiB 1.28 MiB
bfe454a+dirty 7.15 MiB 8.42 MiB 1.26 MiB
d1fd647+dirty 7.15 MiB 8.43 MiB 1.28 MiB
6a70a7e+dirty 7.15 MiB 8.42 MiB 1.26 MiB
276d348+dirty 7.15 MiB 8.42 MiB 1.26 MiB
083f560+dirty 7.15 MiB 8.43 MiB 1.28 MiB
2adbd1e+dirty 7.15 MiB 8.43 MiB 1.28 MiB
49ef936+dirty 7.15 MiB 8.42 MiB 1.26 MiB
8d89cc9+dirty 7.15 MiB 8.41 MiB 1.26 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1231.45 ms 1229.08 ms -2.37 ms
Size 2.63 MiB 4.00 MiB 1.37 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d1fd647+dirty 1219.35 ms 1233.18 ms 13.83 ms
46bd012+dirty 1220.49 ms 1226.89 ms 6.40 ms
8490686+dirty 1227.84 ms 1228.91 ms 1.08 ms
8db9631+dirty 1223.60 ms 1224.56 ms 0.96 ms
6fee48d+dirty 1222.14 ms 1231.44 ms 9.30 ms
5526494+dirty 1224.73 ms 1229.08 ms 4.36 ms
21c9e75+dirty 1237.78 ms 1247.66 ms 9.88 ms
f70acbf+dirty 1235.71 ms 1243.14 ms 7.43 ms
bc9680d+dirty 1221.41 ms 1241.47 ms 20.06 ms
af9331b+dirty 1233.61 ms 1230.50 ms -3.11 ms

App size

Revision Plain With Sentry Diff
d1fd647+dirty 2.63 MiB 3.99 MiB 1.36 MiB
46bd012+dirty 2.63 MiB 3.81 MiB 1.18 MiB
8490686+dirty 2.63 MiB 4.00 MiB 1.36 MiB
8db9631+dirty 2.63 MiB 4.00 MiB 1.36 MiB
6fee48d+dirty 2.63 MiB 3.96 MiB 1.33 MiB
5526494+dirty 2.63 MiB 3.87 MiB 1.24 MiB
21c9e75+dirty 2.63 MiB 3.81 MiB 1.18 MiB
f70acbf+dirty 2.63 MiB 3.98 MiB 1.34 MiB
bc9680d+dirty 2.63 MiB 3.81 MiB 1.18 MiB
af9331b+dirty 2.63 MiB 3.91 MiB 1.28 MiB

Previous results on branch: antonis/ref-java-qual-parse

Startup times

Revision Plain With Sentry Diff
2945cb3+dirty 1237.29 ms 1231.86 ms -5.43 ms

App size

Revision Plain With Sentry Diff
2945cb3+dirty 2.63 MiB 4.00 MiB 1.37 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1204.58 ms 1213.52 ms 8.94 ms
Size 3.19 MiB 4.57 MiB 1.38 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d1fd647+dirty 1218.16 ms 1225.82 ms 7.65 ms
46bd012+dirty 1231.78 ms 1212.30 ms -19.47 ms
8490686+dirty 1227.32 ms 1240.82 ms 13.50 ms
8db9631+dirty 1226.92 ms 1226.06 ms -0.85 ms
6fee48d+dirty 1208.85 ms 1218.52 ms 9.67 ms
5526494+dirty 1217.06 ms 1222.26 ms 5.20 ms
21c9e75+dirty 1206.20 ms 1223.54 ms 17.35 ms
f70acbf+dirty 1239.00 ms 1242.53 ms 3.53 ms
bc9680d+dirty 1228.57 ms 1233.64 ms 5.07 ms
af9331b+dirty 1230.08 ms 1233.24 ms 3.16 ms

App size

Revision Plain With Sentry Diff
d1fd647+dirty 3.19 MiB 4.56 MiB 1.37 MiB
46bd012+dirty 3.19 MiB 4.38 MiB 1.19 MiB
8490686+dirty 3.19 MiB 4.56 MiB 1.38 MiB
8db9631+dirty 3.19 MiB 4.56 MiB 1.38 MiB
6fee48d+dirty 3.19 MiB 4.53 MiB 1.35 MiB
5526494+dirty 3.19 MiB 4.44 MiB 1.25 MiB
21c9e75+dirty 3.19 MiB 4.38 MiB 1.19 MiB
f70acbf+dirty 3.19 MiB 4.54 MiB 1.36 MiB
bc9680d+dirty 3.19 MiB 4.38 MiB 1.19 MiB
af9331b+dirty 3.19 MiB 4.48 MiB 1.29 MiB

Previous results on branch: antonis/ref-java-qual-parse

Startup times

Revision Plain With Sentry Diff
2945cb3+dirty 1231.92 ms 1239.84 ms 7.92 ms

App size

Revision Plain With Sentry Diff
2945cb3+dirty 3.19 MiB 4.57 MiB 1.38 MiB

alwx
alwx reviewed Oct 28, 2025
View reviewed changes
packages/core/android/src/main/java/io/sentry/react/RNSentryModuleImpl.java
return SentryReplayQuality.HIGH;
default:
return SentryReplayQuality.MEDIUM;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So weird this code was written like that before :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even remember how I came up with that or if it was AI magic 😓

@antonis antonis enabled auto-merge (squash) October 29, 2025 09:59
@antonis antonis merged commit 175d098 into main Oct 29, 2025
63 of 65 checks passed
@antonis antonis deleted the antonis/ref-java-qual-parse branch October 29, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alwx alwx alwx approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antonis @alwx