Skip to content

ref: Minor refactoring simplifying replay quality parsing on Android #5305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2025
Merged

ref: Minor refactoring simplifying replay quality parsing on Android #5305

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d13cc01
ref: Minor refactoring simplifying replay quality parsing on Android
antonis Oct 24, 2025
23d8d95
Merge branch 'main' into antonis/ref-java-qual-parse
antonis Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions packages/core/android/src/main/java/io/sentry/react/RNSentryModuleImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,19 +447,15 @@ private SentryReplayQuality parseReplayQuality(@Nullable String qualityString) {
return SentryReplayQuality.MEDIUM;
}

try {
switch (qualityString.toLowerCase(Locale.ROOT)) {
case "low":
return SentryReplayQuality.LOW;
case "medium":
return SentryReplayQuality.MEDIUM;
case "high":
return SentryReplayQuality.HIGH;
default:
return SentryReplayQuality.MEDIUM;
}
} catch (Exception e) {
return SentryReplayQuality.MEDIUM;
switch (qualityString.toLowerCase(Locale.ROOT)) {
case "low":
return SentryReplayQuality.LOW;
case "medium":
return SentryReplayQuality.MEDIUM;
case "high":
return SentryReplayQuality.HIGH;
default:
return SentryReplayQuality.MEDIUM;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So weird this code was written like that before :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even remember how I came up with that or if it was AI magic 😓

}

Expand Down
Loading