Skip to content

Rework reader#345

Merged
ludwiglierhammer merged 76 commits intoglamod:mainfrom
ludwiglierhammer:rework_reader
Jan 15, 2026
Merged

Rework reader#345
ludwiglierhammer merged 76 commits intoglamod:mainfrom
ludwiglierhammer:rework_reader

Conversation

@ludwiglierhammer
Copy link
Collaborator

@ludwiglierhammer ludwiglierhammer commented Dec 17, 2025

This PR is related to #334

modules to rework

  • converters
  • decoders
  • validators
  • reader
  • filereader

tasks

  • disentangle Configurator, FileReader and MDFFileReader
  • update and add docstrings
  • add unit test
  • update tests for mdf_reader.reader
  • update tests for mdf_reader.writer
  • update CHANGELOG
  • update documentation -> see Update documentation #347

@ludwiglierhammer ludwiglierhammer self-assigned this Dec 17, 2025
@ludwiglierhammer ludwiglierhammer added the enhancement New feature or request label Dec 17, 2025
@github-actions
Copy link

Warning
This Pull Request is coming from a fork and must be manually tagged approved
in order to perform additional testing.

@ludwiglierhammer ludwiglierhammer linked an issue Dec 17, 2025 that may be closed by this pull request
@github-actions github-actions bot added the CI label Jan 9, 2026
@ludwiglierhammer
Copy link
Collaborator Author

Hi @JanWillruth, from my side this PR is ready to merge. Please review my changes.

@ludwiglierhammer
Copy link
Collaborator Author

Hi @jtsiddons, in this PR I attempted to untangle the mdf_reader module, make it more readable and modular, and added some unit tests. Feel free to have a look at my changes. I am looking forward to your comments/suggestions. We are in no hurry, so take your time. Hopefully, you will find some time for it.

@ludwiglierhammer
Copy link
Collaborator Author

Hi @jtsiddons, I'll merge this PR. Please contact me or create any new issues if you have any further suggestions or comments.

@ludwiglierhammer ludwiglierhammer merged commit 084d32d into glamod:main Jan 15, 2026
12 checks passed
@jtsiddons
Copy link
Collaborator

Thanks for the changes @ludwiglierhammer. Sorry I've not had chance to look through them yet. I'll update my copies and let you know I have any issues with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

re-work mdf_reader

2 participants

Comments