Skip to content

Conversation

@CyclingNinja
Copy link
Contributor

No description provided.

@CyclingNinja CyclingNinja changed the title Correct code to pass and remove xfails from initial tests Visual tests - correct code to pass and remove xfails Mar 24, 2025
@CyclingNinja CyclingNinja force-pushed the visual_test_alterations branch from dd6ad3a to f5b15d6 Compare March 27, 2025 13:45
@CyclingNinja CyclingNinja force-pushed the visual_test_alterations branch from c7c69e5 to c845ed3 Compare April 7, 2025 09:13
@astrofrog
Copy link
Member

pre-commit.ci autofix

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, though it looks like there might be a genuine failure in the line style test. Once this is fixed, the hashes for the figures should be updated for the two tests which will allow the CI to pass.

@CyclingNinja
Copy link
Contributor Author

pre-commit.ci autofix

@CyclingNinja CyclingNinja force-pushed the visual_test_alterations branch 2 times, most recently from fe83e5b to 923f903 Compare April 10, 2025 15:55
@astrofrog
Copy link
Member

Looking good, I think you just need to update the hashes now!

@CyclingNinja CyclingNinja force-pushed the visual_test_alterations branch 3 times, most recently from d4b8372 to cdcd961 Compare April 11, 2025 09:01
@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 18.46154% with 53 lines in your changes missing coverage. Please review.

Project coverage is 84.41%. Comparing base (f997e7d) to head (cdcd961).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
glue_jupyter/bqplot/scatter/tests/test_visual.py 0.00% 29 Missing ⚠️
glue_jupyter/bqplot/scatter/layer_artist.py 29.41% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
- Coverage   85.07%   84.41%   -0.67%     
==========================================
  Files          91       91              
  Lines        5407     5447      +40     
==========================================
- Hits         4600     4598       -2     
- Misses        807      849      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CyclingNinja CyclingNinja force-pushed the visual_test_alterations branch from cdcd961 to f502c94 Compare July 21, 2025 14:38
@dhomeier dhomeier force-pushed the visual_test_alterations branch from f502c94 to fc591ee Compare September 23, 2025 16:11
@dhomeier
Copy link
Contributor

Seems test_remove is failing now (due to changed number of tests?)
And the two failing image comparisons look like it’s just a change in colourmaps, so just update the hashes again?

@dhomeier dhomeier mentioned this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants