-
Notifications
You must be signed in to change notification settings - Fork 39
Visual tests - correct code to pass and remove xfails #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dd6ad3a to
f5b15d6
Compare
c7c69e5 to
c845ed3
Compare
|
pre-commit.ci autofix |
astrofrog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, though it looks like there might be a genuine failure in the line style test. Once this is fixed, the hashes for the figures should be updated for the two tests which will allow the CI to pass.
|
pre-commit.ci autofix |
fe83e5b to
923f903
Compare
|
Looking good, I think you just need to update the hashes now! |
d4b8372 to
cdcd961
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #479 +/- ##
==========================================
- Coverage 85.07% 84.41% -0.67%
==========================================
Files 91 91
Lines 5407 5447 +40
==========================================
- Hits 4600 4598 -2
- Misses 807 849 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cdcd961 to
f502c94
Compare
for more information, see https://pre-commit.ci
f502c94 to
fc591ee
Compare
|
Seems |
No description provided.