Add recommendations for 3D light shadow bias #5340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
lights-and-shadows-add-bias-tip
branch
from
294c489 to
e2260e4
Compare
clayjohn
approved these changes
Oct 24, 2021
Calinou
force-pushed
the
lights-and-shadows-add-bias-tip
branch
2 times, most recently
from
a618278 to
28e59a0
Compare
Member
Author
|
While testing, I found a bug that affects those recommendations: godotengine/godot#54209 and godotengine/godot#54210 It doesn't affect all projects, but it's a caveat to keep in mind, so I documented it. |
Calinou
force-pushed
the
lights-and-shadows-add-bias-tip
branch
from
28e59a0 to
372f50a
Compare
These are the settings I usually recommend based on my personal experience.
Calinou
force-pushed
the
lights-and-shadows-add-bias-tip
branch
from
372f50a to
2dcf3b0
Compare
Member
|
@clayjohn Friendly reminder to your reminder :) |
clayjohn
reviewed
Oct 30, 2021
Co-authored-by: Clay John <claynjohn@gmail.com>
Member
|
Thanks! |
Calinou
added a commit
that referenced
this pull request
Nov 3, 2021
* Add recommendations for 3D light shadow bias These are the settings I usually recommend based on my personal experience.
Calinou
added a commit
that referenced
this pull request
Nov 3, 2021
* Add recommendations for 3D light shadow bias These are the settings I usually recommend based on my personal experience.
Member
Author
|
Cherry-picked to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the settings I usually recommend based on my personal experience.
Contact shadows should generally be avoided as per godotengine/godot#35316.
These tips also apply to 3.3, but not 4.0 as shadow mapping code was rewritten there.
Preview
Before
After