Skip to content

Conversation

@akien-mga
Copy link
Member

@akien-mga akien-mga commented Oct 28, 2025

Cherry-pick of #112104 for 4.1 to fix CI.

Edit: Added various other cherry-picks to fix the build.

@akien-mga akien-mga requested a review from a team as a code owner October 28, 2025 20:08
@akien-mga akien-mga added this to the 4.1 milestone Oct 28, 2025
@Repiteo
Copy link
Contributor

Repiteo commented Oct 28, 2025

Getting a new error for iOS: -Wmodule-import-in-extern-c. Haven't run into this on the modern branches, so it could be something inherent to 4.1

@akien-mga
Copy link
Member Author

Yeah that's related to 146ba41 which was cherry-picked to 4.1, but it seems there's still a case of mixup of C and C++ in Vulkan headers.

@akien-mga
Copy link
Member Author

akien-mga commented Oct 28, 2025

It seems we need to patch the old vulkan in 4.1 with bits of this: KhronosGroup/Vulkan-Headers@9c37439

bruvzg and others added 4 commits October 28, 2025 22:07
…s with newer MinGW SDKs.

(cherry picked from commit c363e13)
(cherry picked from commit acdb866)

Adds some more fixes for 4.5.

Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
Should resolve issue godotengine#83342

(cherry picked from commits b97cb5e
and 21ae69a)
@akien-mga akien-mga force-pushed the 4.1-fix-gcc-warnings branch from e69ab66 to a477f23 Compare October 28, 2025 21:22
@akien-mga akien-mga requested review from a team as code owners October 28, 2025 21:22
@akien-mga akien-mga changed the title [4.1] Core: Sidestep MinGW-GCC false-positive warnings [4.1] CI: Fix build with latest MinGW-GCC 15 Oct 28, 2025
@akien-mga akien-mga merged commit 8188bc7 into godotengine:4.1 Oct 28, 2025
17 checks passed
@akien-mga akien-mga deleted the 4.1-fix-gcc-warnings branch October 28, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants