Fix RD header generation for raytracing shaders.#118082
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Apr 2, 2026
Merged
Fix RD header generation for raytracing shaders.#118082Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
clayjohn
approved these changes
Apr 2, 2026
Repiteo
approved these changes
Apr 2, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script generates empty strings for every raytracing stage even if they aren't actually present in the file. This causes the compilation to fail since glslang tries to compile empty strings.
I also made raytracing detection check for all raytracing stages instead of just ray generation.