Skip to content

Fix RD header generation for raytracing shaders. #118082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Repiteo merged 1 commit into from
Apr 2, 2026
+25 −16
Merged

Fix RD header generation for raytracing shaders. #118082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 25 additions & 16 deletions glsl_builders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,19 @@ def include_file_in_rd_header(filename: str, header_data: RDHeaderStruct, depth:
return header_data


def build_rd_header_lines_for_raytracing_stage(lines, stage: str):
if lines:
return f"""\
static const char _{stage}_code[] = {{
{to_raw_cstring(lines)}
}};
"""
else:
return f"""\
static const char *_{stage}_code = nullptr;
"""


def build_rd_header(filename: str, shader: str) -> None:
include_file_in_rd_header(shader, header_data := RDHeaderStruct(), 0)
class_name = os.path.basename(shader).replace(".glsl", "").title().replace("_", "").replace(".", "") + "ShaderRD"
Expand All @@ -189,23 +202,19 @@ class {class_name} : public ShaderRD {{
{class_name}() {{
""")

if header_data.raygen_lines:
if (
header_data.raygen_lines
or header_data.any_hit_lines
or header_data.closest_hit_lines
or header_data.miss_lines
or header_data.intersection_lines
):
file.write(build_rd_header_lines_for_raytracing_stage(header_data.raygen_lines, "raygen"))
file.write(build_rd_header_lines_for_raytracing_stage(header_data.any_hit_lines, "any_hit"))
file.write(build_rd_header_lines_for_raytracing_stage(header_data.closest_hit_lines, "closest_hit"))
file.write(build_rd_header_lines_for_raytracing_stage(header_data.miss_lines, "miss"))
file.write(build_rd_header_lines_for_raytracing_stage(header_data.intersection_lines, "intersection"))
file.write(f"""\
static const char _raygen_code[] = {{
{to_raw_cstring(header_data.raygen_lines)}
}};
static const char _any_hit_code[] = {{
{to_raw_cstring(header_data.any_hit_lines)}
}};
static const char _closest_hit_code[] = {{
{to_raw_cstring(header_data.closest_hit_lines)}
}};
static const char _miss_code[] = {{
{to_raw_cstring(header_data.miss_lines)}
}};
static const char _intersection_code[] = {{
{to_raw_cstring(header_data.intersection_lines)}
}};
setup_raytracing(_raygen_code, _any_hit_code, _closest_hit_code, _miss_code, _intersection_code, "{class_name}");
""")
elif header_data.compute_lines:
Expand Down
Loading