Skip to content

Addresses PR Feedback #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ndegwamartin wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −17
Open

Addresses PR Feedback #1529

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d197de1
Addresses PR Feedback
ndegwamartin Nov 28, 2025
2e63c6a
Merge branch 'master' into error-prone-tests-2
ndegwamartin Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 7 additions & 17 deletions pipelines/common/src/test/java/com/google/fhir/analytics/ParquetUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ public void createSingleOutput() throws IOException, ProfileException, ViewAppli
rootPath = Files.createTempDirectory("PARQUET_TEST");
parquetUtil =
new ParquetUtil(
FhirVersionEnum.R4, "", rootPath.toString(), "", "", null, 0, 0, "", 1, false);
FhirVersionEnum.R4, "", rootPath.toString(), "", "", "", 0, 0, "", 1, false);
IParser parser = avroConversionUtil.getFhirContext().newJsonParser();
Bundle bundle = parser.parseResource(Bundle.class, observationBundle);
for (Bundle.BundleEntryComponent entry : bundle.getEntry()) {
Expand Down Expand Up @@ -179,7 +179,7 @@ public void createMultipleOutputByTime()
rootPath = Files.createTempDirectory("PARQUET_TEST");
parquetUtil =
new ParquetUtil(
FhirVersionEnum.R4, "", rootPath.toString(), "", "", null, 1, 0, "", 1, false);
FhirVersionEnum.R4, "", rootPath.toString(), "", "", "", 1, 0, "", 1, false);
IParser parser = avroConversionUtil.getFhirContext().newJsonParser();
Bundle bundle = parser.parseResource(Bundle.class, observationBundle);
for (Bundle.BundleEntryComponent entry : bundle.getEntry()) {
Expand Down Expand Up @@ -222,17 +222,7 @@ public void createSingleOutputWithRowGroupSize()
final int rowGroupSize = approximateMemSizeOfOneObservarion * 90;
parquetUtil =
new ParquetUtil(
FhirVersionEnum.R4,
"",
rootPath.toString(),
"",
"",
null,
0,
rowGroupSize,
"",
1,
false);
FhirVersionEnum.R4, "", rootPath.toString(), "", "", "", 0, rowGroupSize, "", 1, false);
IParser parser = avroConversionUtil.getFhirContext().newJsonParser();
Bundle bundle = parser.parseResource(Bundle.class, observationBundle);
// There are 6 resources in the bundle, so we write 17*6 (>100) resources, such that the page
Expand Down Expand Up @@ -310,7 +300,7 @@ public void writeObservationWithBigDecimalValue()
rootPath = Files.createTempDirectory("PARQUET_TEST");
parquetUtil =
new ParquetUtil(
FhirVersionEnum.R4, "", rootPath.toString(), "", "", null, 0, 0, "", 1, false);
FhirVersionEnum.R4, "", rootPath.toString(), "", "", "", 0, 0, "", 1, false);
String observationStr =
Resources.toString(
Resources.getResource("observation_decimal.json"), StandardCharsets.UTF_8);
Expand All @@ -326,7 +316,7 @@ public void writeObservationBundleWithDecimalConversionIssue()
rootPath = Files.createTempDirectory("PARQUET_TEST");
parquetUtil =
new ParquetUtil(
FhirVersionEnum.R4, "", rootPath.toString(), "", "", null, 0, 0, "", 1, false);
FhirVersionEnum.R4, "", rootPath.toString(), "", "", "", 0, 0, "", 1, false);
String observationBundleStr =
Resources.toString(
Resources.getResource("observation_decimal_bundle.json"), StandardCharsets.UTF_8);
Expand All @@ -342,7 +332,7 @@ public void writeObservationBundleWithMultipleProfiles()
rootPath = Files.createTempDirectory("PARQUET_TEST");
parquetUtil =
new ParquetUtil(
FhirVersionEnum.R4, "", rootPath.toString(), "", "", null, 0, 0, "", 1, false);
FhirVersionEnum.R4, "", rootPath.toString(), "", "", "", 0, 0, "", 1, false);

String patientStr =
Resources.toString(Resources.getResource("patient_bundle.json"), StandardCharsets.UTF_8);
Expand Down Expand Up @@ -374,7 +364,7 @@ public void writeQuestionnaireResponse()
rootPath.toString(),
"",
"",
null,
"",
0,
0,
"",
Expand Down
Loading