- 
                Notifications
    
You must be signed in to change notification settings  - Fork 8
 
Compile dependencies per platform #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            wsxrdv
  wants to merge
  20
  commits into
  google:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
wsxrdv:pin_per_os
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
      
        
          +35,771
        
        
          −1,239
        
        
          
        
      
    
  
  
     Open
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            20 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      690d857
              
                Compile dependencies per platform
              
              
                wsxrdv 7b13b5e
              
                [squash] forgotten requirements.txt files
              
              
                wsxrdv 44444c0
              
                [squash] lint
              
              
                wsxrdv e22af03
              
                [squash]
              
              
                wsxrdv 3915206
              
                [squash]
              
              
                wsxrdv aea9161
              
                [squash]
              
              
                wsxrdv 1fde784
              
                [squash] TODO update all requirements references
              
              
                wsxrdv 4dddb84
              
                [squash]
              
              
                wsxrdv dc70904
              
                [squash]
              
              
                wsxrdv e9783e5
              
                [squash]
              
              
                wsxrdv 1e678ab
              
                [squash]
              
              
                wsxrdv 283c00c
              
                [squash]
              
              
                wsxrdv 37109db
              
                [squash]
              
              
                wsxrdv a923685
              
                [squash]
              
              
                wsxrdv 13cdeea
              
                [squash]
              
              
                wsxrdv af35335
              
                [squash]
              
              
                wsxrdv 66a4717
              
                [squash]
              
              
                wsxrdv 979414a
              
                [squash]
              
              
                wsxrdv f2a6a67
              
                [squash]
              
              
                wsxrdv 9e4a84c
              
                Merge branch 'main' into pin_per_os
              
              
                wsxrdv File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              This file was deleted.
      
      Oops, something went wrong.
      
    
  
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| 
          
            
          
           | 
    @@ -81,4 +81,5 @@ tinyaes | |
| tobytes | ||
| uoffset | ||
| xored | ||
| ziglang | ||
| zstd | ||
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all this seems a reimplementation of what uv (or pip itself) should do. uv.lock (same for poetry) already contains all pins for all requirements for all supported architectures / python versions. I guess you need to keep all the requirements for all the combinations of OS/python version because of limitations of the pip requirements format... I'd take this opportunity to ditch pip, this seems a nightmare to properly maintain :-)