Fix logging inconsistency: unify metrics logging to use global_steps #491
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Logging for metrics returned by loss functions via aux was at a
_iter_stepslevel,whereas other metrics were logged at a
global_stepslevel. The progress bar forGRPO/PPO was at a
_iter_stepslevel. This inconsistency made it confusing forusers to pass
max_stepsat a_iter_stepslevel, and not atglobal_stepslevel.Solution
Unified logging to use
global_stepsconsistently across all components:Files Changed
tunix/sft/peft_trainer.py- Added global_steps property and updated progress bartunix/sft/dpo/dpo_trainer.py- Updated logging methods to use global_stepsTesting
Resolves #390
Colab Notebook
https://colab.research.google.com/drive/1hMelDYWB5w3v3W6anOChPDFXruMCbjlY?usp=sharing
Checklist