Skip to content

Fix logging inconsistency: unify metrics logging to use global_steps #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix logging inconsistency: unify metrics logging to use global_steps #491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tunix/sft/peft_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ def train(
if self.config.max_steps is not None and self._pbar is None:
self._pbar = progress_bar.ProgressBar(
metrics_logger=self.metrics_logger,
initial_steps=self._train_steps,
initial_steps=self.global_steps,
max_steps=self.config.max_steps,
description=self.config.pbar_description,
)
Expand Down Expand Up @@ -713,6 +713,11 @@ def train_steps(self) -> int:
"""Returns the number of train steps taken."""
return self._train_steps

@property
def global_steps(self) -> int:
"""Returns the number of global steps taken (same as train_steps for compatibility)."""
return self._train_steps

@property
def iter_steps(self) -> int:
"""Returns the number of iterator steps taken."""
Expand Down