-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore: bump synthtool to skip venv for nox format #15550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ohmayr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the version of the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the pinned commit for synthtool in the generator Dockerfile. The change is correct, but I've added a suggestion to include an inline comment explaining the purpose of the new commit hash. This will improve code maintainability by providing context directly where it's needed.
| RUN git clone https://github.com/googleapis/synthtool.git synthtool && \ | ||
| cd synthtool && \ | ||
| git checkout 6702a344265de050bceaff45d62358bb0023ba7d | ||
| git checkout 5dc7e990bb38ef8bc3d71cae6304e74d3037b9ef |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For maintainability, it's good practice to add a comment explaining why a specific commit hash is being used. This provides context for future developers directly in the code, explaining the purpose of this dependency pin without needing to check git history or pull requests.
git checkout 5dc7e990bb38ef8bc3d71cae6304e74d3037b9ef # Pin to commit that skips venv for nox format
bump synthtool to skip venv for nox format