Skip to content

chore: bump synthtool to skip venv for nox format #15550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ohmayr merged 1 commit into from
Feb 9, 2026
Merged

chore: bump synthtool to skip venv for nox format #15550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .generator/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ RUN tar -xvf pandoc-${PANDOC_VERSION}-linux-amd64.tar.gz -C pandoc-binary --stri
# This needs to be a single command so that the git clone command is not cached
RUN git clone https://github.com/googleapis/synthtool.git synthtool && \
cd synthtool && \
git checkout 6702a344265de050bceaff45d62358bb0023ba7d
git checkout 5dc7e990bb38ef8bc3d71cae6304e74d3037b9ef
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For maintainability, it's good practice to add a comment explaining why a specific commit hash is being used. This provides context for future developers directly in the code, explaining the purpose of this dependency pin without needing to check git history or pull requests.

    git checkout 5dc7e990bb38ef8bc3d71cae6304e74d3037b9ef # Pin to commit that skips venv for nox format


# --- Final Stage ---
# This stage creates the lightweight final image, copying only the
Expand Down
Loading