Skip to content

refactor(pubsub): move shutdown logic into BatchWorker #4425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PhongChuong merged 6 commits into from
Jan 28, 2026
Merged

refactor(pubsub): move shutdown logic into BatchWorker #4425

PhongChuong merged 6 commits into from
Jan 28, 2026
+44 −29

Conversation

@PhongChuong
Copy link
Collaborator

@PhongChuong PhongChuong commented Jan 27, 2026

Towards: #4012

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jan 27, 2026
@codecov
Copy link

codecov bot commented Jan 27, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.00%. Comparing base (cee52c2) to head (ba34210).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4425   +/-   ##
=======================================
  Coverage   94.99%   95.00%           
=======================================
  Files         193      193           
  Lines        7294     7307   +13     
=======================================
+ Hits         6929     6942   +13     
  Misses        365      365

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PhongChuong PhongChuong marked this pull request as ready for review January 27, 2026 19:20
@PhongChuong PhongChuong requested a review from a team as a code owner January 27, 2026 19:20
@PhongChuong PhongChuong requested a review from suzmue January 27, 2026 19:21
suzmue
suzmue approved these changes Jan 27, 2026
View reviewed changes
@PhongChuong PhongChuong merged commit 341e7fd into googleapis:main Jan 28, 2026
31 checks passed
@PhongChuong PhongChuong deleted the pubsubShutdown branch January 28, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suzmue suzmue suzmue approved these changes

Assignees

No one assigned

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PhongChuong @suzmue