Skip to content

fix(jdbc): return null for invalid URLs in connect() to comply with JDBC spec #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
keshavdandeva wants to merge 1 commit into from
Closed

fix(jdbc): return null for invalid URLs in connect() to comply with JDBC spec #4085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions google-cloud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryDriver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,7 @@ public Connection connect(String url, Properties info) throws SQLException {
this.toString()));
return connection;
} else {
throw new IllegalArgumentException(
"Invalid URL provided, must start with \"jdbc:bigquery:\"");
return null;
}
} catch (IOException e) {
LOG.warning("Getting a warning: " + e.getMessage());
Expand Down
5 changes: 2 additions & 3 deletions ...-cloud-bigquery-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryDriverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
package com.google.cloud.bigquery.jdbc;

import static com.google.common.truth.Truth.assertThat;
import static org.junit.Assert.assertThrows;

import java.sql.Connection;
import java.sql.DriverPropertyInfo;
Expand All @@ -36,8 +35,8 @@ public void setUp() {
}

@Test
public void testInvalidURLDoesNotConnect() {
assertThrows(IllegalArgumentException.class, () -> bigQueryDriver.connect("badURL.com", null));
public void testInvalidURLReturnsNull() throws SQLException {
assertThat(bigQueryDriver.connect("badURL.com", null)).isNull();
}

@Test
Expand Down
Loading