feat: [BBND-1376] Support external wallets in the SDK#1415
Merged
rubenbermejo3 merged 21 commits intodevelopfrom Mar 10, 2026
Merged
feat: [BBND-1376] Support external wallets in the SDK#1415rubenbermejo3 merged 21 commits intodevelopfrom
rubenbermejo3 merged 21 commits intodevelopfrom
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
40df3bb to
fb20d21
Compare
Signed-off-by: rbermejo <ruben@io.builders>
fb20d21 to
ce9a592
Compare
Signed-off-by: rbermejo <ruben@io.builders>
Signed-off-by: Ruben <ruben@io.builders>
Signed-off-by: Ruben <ruben@io.builders>
Signed-off-by: Ruben <ruben@io.builders>
Signed-off-by: adrian <adrian@io.builders>
Signed-off-by: adrian <adrian@io.builders>
Signed-off-by: Ruben <ruben@io.builders>
…pression Signed-off-by: adrian <adrian@io.builders>
Signed-off-by: Ruben <ruben@io.builders>
…te handling Signed-off-by: adrian <adrian@io.builders>
…lude proxy address handling Signed-off-by: adrian <adrian@io.builders>
Signed-off-by: Ruben <ruben@io.builders>
…transaction data without affecting the rest of methods (retro-compability) Signed-off-by: Ruben <ruben@io.builders>
Signed-off-by: Ruben <ruben@io.builders>
…ptAdapters Signed-off-by: Ruben <ruben@io.builders>
Signed-off-by: Ruben <ruben@io.builders>
Signed-off-by: Ruben <ruben@io.builders>
Signed-off-by: Ruben <ruben@io.builders>
Signed-off-by: Ruben <ruben@io.builders>
Detalle: reemplazar
|
| Archivo | Ocurrencias |
|---|---|
packages/sdk/src/port/in/StableCoin.ts |
22 |
packages/sdk/src/port/in/Role.ts |
10 |
packages/sdk/src/port/in/CustomFees.ts |
3 |
packages/sdk/src/port/in/Management.ts |
3 |
packages/sdk/src/port/in/ReserveDataFeed.ts |
1 |
Cambio a aplicar en cada archivo:
// 1. Añadir import (relativo desde packages/sdk/src/port/in/)
import { EmptyResponse } from '../../app/service/error/EmptyResponse.js';
// 2. Sustituir todas las guardas (patrón: replace_all)
// Antes
if (!response.serializedTransactionData) throw new Error("Expected serialized transaction data but none was returned");
// Después
if (!response.serializedTransactionData) throw new EmptyResponse('buildXxx');Referencia: mismo patrón usado en
TransactionService.ts:350:if (!res.id) throw new EmptyResponse(className);
Signed-off-by: Ruben <ruben@io.builders>
|
❌ The last analysis has failed. |
ruben-martinez-iob
approved these changes
Mar 9, 2026
jaime-iobermudez
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements support for external wallets in the SDK, allowing external systems to construct transactions without executing them, enabling custom signing and submission workflows.
Related issue(s):
Fixes #BBND-1376
Notes for reviewer:
Checklist