Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ce9a592
feat: Adapt adapters (WIP)
rubenbermejo3 Mar 2, 2026
325e9c9
fix: fix sonar qube
rubenbermejo3 Mar 2, 2026
0922a06
fix: adapt create method
rubenbermejo3 Mar 3, 2026
1f8955b
fix: adapt example scripts
rubenbermejo3 Mar 3, 2026
2456411
fix: add temporal script to test everything works
rubenbermejo3 Mar 3, 2026
c20613b
fix: fix test external evm
adrianIOB Mar 3, 2026
568037b
fix: update associate tests to skip due to evmAddress handling issue
adrianIOB Mar 3, 2026
697f442
fix: make ExternalEVMTransactionAdapter works with all methods
rubenbermejo3 Mar 3, 2026
c26861d
feat: enhance EVM transaction handling with retry logic and error sup…
adrianIOB Mar 4, 2026
ae961f5
fix: add testExternalHedera.ts
rubenbermejo3 Mar 4, 2026
31f891b
feat: enhance stablecoin creation with reserve configuration and upda…
adrianIOB Mar 4, 2026
2da1cb8
feat: enhance createStablecoin and fundProxyWithHBAR functions to inc…
adrianIOB Mar 4, 2026
5be4cdc
feat: improve tests
rubenbermejo3 Mar 4, 2026
d021d79
feat: new buildXXX() methods to just build the associated serialized …
rubenbermejo3 Mar 5, 2026
8579739
fix: fix related test
rubenbermejo3 Mar 5, 2026
c70cbd7
Merge remote-tracking branch 'origin/develop' into feat/BBND-1376_Ada…
rubenbermejo3 Mar 6, 2026
3d6be7d
chore: update symmlinks in workspace
rubenbermejo3 Mar 6, 2026
43279f9
fix: fix tests
rubenbermejo3 Mar 6, 2026
abb5b34
fix: last code review changes
rubenbermejo3 Mar 6, 2026
71b807b
fix: fix pipelines
rubenbermejo3 Mar 6, 2026
338464f
fix: code review changes added
rubenbermejo3 Mar 9, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/create-env-file/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ runs:
echo "TESTNET_PRIVATE_KEY_0=$TESTNET_PRIVATE_KEY_0" >> $GITHUB_ENV
echo "TESTNET_PRIVATE_KEY_1=$TESTNET_PRIVATE_KEY_1" >> $GITHUB_ENV

working-directory: contracts
working-directory: packages/contracts

- name: Create .env file for SDK
if: ${{ inputs.module == 'sdk' }}
Expand Down Expand Up @@ -98,4 +98,4 @@ runs:
FACTORY_ADDRESS=0.0.7353542
RESOLVER_ADDRESS=0.0.7353500
EOF
working-directory: sdk
working-directory: packages/sdk
2 changes: 1 addition & 1 deletion .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:

- name: Install Contracts
run: npm ci
working-directory: contracts
working-directory: packages/contracts

# * Build contracts
- name: Build Contracts
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ export default class HoldStableCoinService extends Service {
public async createHold(req: CreateHoldRequest): Promise<void> {
let holdId: number;
await utilsService.showSpinner(
StableCoin.createHold(req).then((response) => (holdId = response.holdId)),
StableCoin.createHold(req).then(
(response) => (holdId = 'holdId' in response ? response.holdId : 0),
),
{
text: language.getText('state.loading'),
successText: language.getText('state.loadCompleted') + '\n',
Expand All @@ -68,7 +70,7 @@ export default class HoldStableCoinService extends Service {
let holdId: number;
await utilsService.showSpinner(
StableCoin.createHoldByController(req).then(
(response) => (holdId = response.holdId),
(response) => (holdId = 'holdId' in response ? response.holdId : 0),
),
{
text: language.getText('state.loading'),
Expand Down
7 changes: 6 additions & 1 deletion apps/web/src/services/SDKService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import type {
ReserveViewModel,
ResetSupplierAllowanceRequest,
RevokeMultiRolesRequest,
SerializedTransactionData,
StableCoinCapabilities,
StableCoinListViewModel,
StableCoinViewModel,
Expand Down Expand Up @@ -477,7 +478,11 @@ export class SDKService {

public static async createStableCoin(
createRequest: CreateRequest,
): Promise<{ coin: StableCoinViewModel; reserve: ReserveViewModel } | null> {
): Promise<
| { coin: StableCoinViewModel; reserve: ReserveViewModel }
| SerializedTransactionData
| null
> {
return await StableCoin.create(createRequest);
}

Expand Down
22 changes: 0 additions & 22 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 6 additions & 4 deletions packages/sdk/__tests__/port/in/CustomFees.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ import { MirrorNode } from '../../../src/domain/context/network/MirrorNode.js';
import { JsonRpcRelay } from '../../../src/domain/context/network/JsonRpcRelay.js';
import { CommandBus } from '../../../src/core/command/CommandBus.js';
import { ConnectCommand } from '../../../src/app/usecase/command/network/connect/ConnectCommand.js';
import { TransactionResult } from '../../../src/domain/context/transaction/TransactionResult.js';

const mirrorNode: MirrorNode = {
name: MIRROR_NODE.name,
Expand Down Expand Up @@ -103,7 +104,8 @@ describe('🧪 [ADAPTER] ClientTransactionAdapter with ECDSA accounts', () => {
decimals: stableCoinCapabilitiesHTS.coin.decimals,
amount: amount.toString(),
});
const result = await Fees.addFixedFee(fixedFee);
const result = await Fees.addFixedFee(fixedFee) as TransactionResult;

expect(result).toBeTruthy();
expect(result.success).toBeTruthy();
expect(result.transactionId).toBeTruthy();
Expand Down Expand Up @@ -137,7 +139,7 @@ describe('🧪 [ADAPTER] ClientTransactionAdapter with ECDSA accounts', () => {
net: net,
});

const result = await Fees.addFractionalFee(FractionalFee);
const result = await Fees.addFractionalFee(FractionalFee) as TransactionResult;
expect(result).toBeTruthy();
expect(result.success).toBeTruthy();
expect(result.transactionId).toBeTruthy();
Expand Down Expand Up @@ -172,7 +174,7 @@ describe('🧪 [ADAPTER] ClientTransactionAdapter with ECDSA accounts', () => {
net: net,
});

const result = await Fees.addFractionalFee(FractionalFee);
const result = await Fees.addFractionalFee(FractionalFee) as TransactionResult;
expect(result).toBeTruthy();
expect(result.success).toBeTruthy();
expect(result.transactionId).toBeTruthy();
Expand Down Expand Up @@ -241,7 +243,7 @@ describe('🧪 [ADAPTER] ClientTransactionAdapter with ECDSA accounts', () => {
tokenId: stableCoinCapabilitiesHTS.coin.tokenId!.toString(),
});

const result = await Fees.updateCustomFees(newFees);
const result = await Fees.updateCustomFees(newFees) as TransactionResult;
expect(result).toBeTruthy();
expect(result.success).toBeTruthy();
expect(result.transactionId).toBeTruthy();
Expand Down
7 changes: 4 additions & 3 deletions packages/sdk/__tests__/port/in/Management.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ import { JsonRpcRelay } from '../../../src/domain/context/network/JsonRpcRelay.j
import { CommandBus } from '../../../src/core/command/CommandBus.js';
import { ConnectCommand } from '../../../src/app/usecase/command/network/connect/ConnectCommand.js';
import ConfigInfoViewModel from '../../../src/port/in/response/ConfigInfoViewModel.js';
import { TransactionResult } from '../../../src/domain/context/transaction/TransactionResult.js';

const mirrorNode: MirrorNode = {
name: MIRROR_NODE.name,
Expand Down Expand Up @@ -95,7 +96,7 @@ describe('🧪 Management test', () => {
tokenId,
resolver,
});
const res = await Management.updateResolver(request);
const res = await Management.updateResolver(request) as TransactionResult;
const configInfo = await Management.getConfigInfo(
new GetConfigInfoRequest({
tokenId,
Expand All @@ -113,7 +114,7 @@ describe('🧪 Management test', () => {
configVersion: newConfigVersion,
tokenId,
});
const res = await Management.updateConfigVersion(request);
const res = await Management.updateConfigVersion(request) as TransactionResult;
const configInfo = await Management.getConfigInfo(
new GetConfigInfoRequest({
tokenId,
Expand All @@ -134,7 +135,7 @@ describe('🧪 Management test', () => {
configVersion: configVersion,
tokenId,
});
const res = await Management.updateConfig(request);
const res = await Management.updateConfig(request) as TransactionResult;
const configInfo = await Management.getConfigInfo(
new GetConfigInfoRequest({
tokenId,
Expand Down
3 changes: 2 additions & 1 deletion packages/sdk/__tests__/port/in/Reserve.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import {
RESOLVER_ADDRESS,
} from '../../config.js';
import Injectable from '../../../src/core/Injectable.js';
import { TransactionResult } from '../../../src/domain/context/transaction/TransactionResult.js';

describe('🧪 Reserve test', () => {
const stableCoinSC = {
Expand Down Expand Up @@ -95,7 +96,7 @@ describe('🧪 Reserve test', () => {
reserveAddress: reserveAddress,
reserveAmount: '0',
}),
);
) as TransactionResult;
expect(result).toBeTruthy();
expect(result.transactionId).toBeTruthy();

Expand Down
Loading
Loading