Skip to content

[1.10.x] streaming: fix not being able to enable streaming #10526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dnephin merged 1 commit into from
Jun 30, 2021
Merged

[1.10.x] streaming: fix not being able to enable streaming #10526

dnephin merged 1 commit into from
Jun 30, 2021

Conversation

@dnephin
Copy link
Contributor

@dnephin dnephin commented Jun 29, 2021

Backport #10514 to 1.10.x

@dnephin
Merge pull request #10514 from hashicorp/dnephin/actually-enable-stre…
2dbd823 
…aming

streaming: fix not being able to enable streaming
@dnephin dnephin added theme/streaming Related to Streaming connections between server and client pr/no-changelog PR does not need a corresponding .changelog entry labels Jun 29, 2021
@github-actions github-actions bot added theme/health-checks Health Check functionality type/docs Documentation needs to be created/updated/clarified labels Jun 29, 2021
@hashicorp-ci
Copy link
Contributor

hashicorp-ci commented Jun 29, 2021

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@dnephin dnephin requested a review from a team June 29, 2021 20:56
dhiaayachi
dhiaayachi approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@dhiaayachi dhiaayachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dnephin,
Thank you for back porting this
I don't have a lot of knowledge of the streaming functionality but reading the original PR and reading the change it LGTM

@dnephin dnephin merged commit 1d65962 into release/1.10.x Jun 30, 2021
@dnephin dnephin deleted the dnephin/backport-streaming-enable branch June 30, 2021 20:45
@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Jun 30, 2021

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/401794.

@rboyer rboyer mentioned this pull request Aug 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dhiaayachi dhiaayachi dhiaayachi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr/no-changelog PR does not need a corresponding .changelog entry theme/health-checks Health Check functionality theme/streaming Related to Streaming connections between server and client type/docs Documentation needs to be created/updated/clarified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dnephin @hashicorp-ci @hc-github-team-consul-core @dhiaayachi