Extend checks for more Python-s and fix annotations for Python 3.8#78
Merged
Extend checks for more Python-s and fix annotations for Python 3.8#78
Conversation
iamleot
force-pushed
the
python-matrix-versions-and-support-3.8
branch
2 times, most recently
from
ab504fd to
b892829
Compare
Add a matrix in order to check at least: - oldest Python version - default Python version on pkgsrc-current - newest Python version Set `fail-fast` to `false` (by default it is `true`) in order to run all matrix jobs to see all Python versions that fail instead of pointing out only the first (and non-deterministic) one that fails. Related to #49 and #71.
iamleot
force-pushed
the
python-matrix-versions-and-support-3.8
branch
from
b892829 to
4bc082f
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend checks for more Python-s
Add a matrix in order to check at least:
Set
fail-fasttofalse(by default it istrue) in order to run all matrix jobs to see all Python versions that fail instead of pointing out only the first (and non-deterministic) one that fails.Switch to use typing.Dict
Python 3.8 annotations needs Dict from typing.Dict (i.e. direct `dict is not usable).
Switch to use it in order to be usable from all Python versions.
Related/closes #49 and #71.