-
Notifications
You must be signed in to change notification settings - Fork 794
[SYCL][NFC] Extend getKernelNamesUsingAssert to support general function names #20488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
…ion names Signed-off-by: jinge90 <ge.jin@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, just wondering if you are planning any follow up patches to make use of this extension? Just to understand why we need this extended.
Co-authored-by: Marcos Maronas <marcos.maronas@intel.com>
Co-authored-by: Marcos Maronas <marcos.maronas@intel.com>
|
@intel/llvm-gatekeepers please consider merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why manual BFS instead of llvm/include/llvm/Analysis/{CallGraph.h,LazyCallGraph.h}?
And if call graphs above are not suitable, then GraphTraits specialization to enable generic BFS traversal would still be better, IMO.
Hi, @aelovikov-intel |
Currently, we have getKernelNamesUsingAssert to detect all SPIR kernels which use assert functions via BFS. This PR extend it in 2 points:
We may need to check other special function and can easily call it instead of adding a new getKernelNamesUsingXXX.