Skip to content

[SYCL][NFC] Extend getKernelNamesUsingAssert to support general function names #20488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2025
+19 −9
Merged

[SYCL][NFC] Extend getKernelNamesUsingAssert to support general function names #20488

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80efdd1
[SYCL][NFC] Extend getKernelNamesUsingAssert to support general funct…
jinge90 Oct 28, 2025
1d82d9d
Update llvm/lib/SYCLPostLink/ComputeModuleRuntimeInfo.cpp
jinge90 Oct 29, 2025
bbabb70
Update llvm/lib/SYCLPostLink/ComputeModuleRuntimeInfo.cpp
jinge90 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions llvm/lib/SYCLPostLink/ComputeModuleRuntimeInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,12 @@ bool isModuleUsingTsan(const Module &M) {
// Optional.
// Otherwise, it returns an Optional containing a list of reached
// SPIR kernel function's names.
static std::optional<std::vector<StringRef>>
traverseCGToFindSPIRKernels(const Function *StartingFunction) {
static std::optional<std::vector<StringRef>> traverseCGToFindSPIRKernels(
const std::vector<Function *> &StartingFunctionVec) {
std::queue<const Function *> FunctionsToVisit;
std::unordered_set<const Function *> VisitedFunctions;
FunctionsToVisit.push(StartingFunction);
for (const Function *FPtr : StartingFunctionVec)
FunctionsToVisit.push(FPtr);
std::vector<StringRef> KernelNames;

while (!FunctionsToVisit.empty()) {
Expand Down Expand Up @@ -106,13 +107,20 @@ traverseCGToFindSPIRKernels(const Function *StartingFunction) {
return {std::move(KernelNames)};
}

static std::vector<StringRef> getKernelNamesUsingAssert(const Module &M) {
auto *DevicelibAssertFailFunction = M.getFunction("__devicelib_assert_fail");
if (!DevicelibAssertFailFunction)
static std::vector<StringRef>
getKernelNamesUsingSpecialFunctions(const Module &M,
const std::vector<StringRef> &FNames) {
std::vector<Function *> SpecialFunctionVec;
for (const auto Fn : FNames) {
Function *FPtr = M.getFunction(Fn);
if (FPtr)
SpecialFunctionVec.push_back(FPtr);
}

if (SpecialFunctionVec.size() == 0)
return {};

auto TraverseResult =
traverseCGToFindSPIRKernels(DevicelibAssertFailFunction);
auto TraverseResult = traverseCGToFindSPIRKernels(SpecialFunctionVec);

if (TraverseResult.has_value())
return std::move(*TraverseResult);
Expand Down Expand Up @@ -442,7 +450,9 @@ PropSetRegTy computeModuleProperties(const Module &M,
PropSet.add(PropSetRegTy::SYCL_MISC_PROP, "optLevel", OptLevel);
}
{
std::vector<StringRef> FuncNames = getKernelNamesUsingAssert(M);
std::vector<StringRef> AssertFuncNames{"__devicelib_assert_fail"};
std::vector<StringRef> FuncNames =
getKernelNamesUsingSpecialFunctions(M, AssertFuncNames);
for (const StringRef &FName : FuncNames)
PropSet.add(PropSetRegTy::SYCL_ASSERT_USED, FName, true);
}
Expand Down
Loading