-
Notifications
You must be signed in to change notification settings - Fork 31
Fix components not refreshing during hmr #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
We can consider importing different function from |
|
Ideally we should support the new Activity component |
|
I had an idea that I need to think over but instead of introducing arbitrary timeout to dispose, maybe we can dispose in the nextTick/nextAnimationFrame or something like that |
|
The activity component (which I believe was called the offscreen API at some point in time in the past) is going to be tough, because if a component goes off and onscreen, React will:
But for something like The additional problem is that you might invoke a mutation in
But yeah! |
Fixes HMR by method described in #264
Follow up to #264
Rebase of #305