generate raw response types

[PatrykWalach]

#177

---

This is part 3 of 3 in a stack made with GitButler:

•  3  generate raw response types #764 👈
•  2  add __typename in create_merged_selection.rs if selections empty #766
•  1  add __typename to unions #765

[PatrykWalach]

needs FIX

[rbalicki2]

Hell yeah. I can't wait to have a normalizeData API that has types that we can sent to Randall 🤩

[rbalicki2]

This would be true for GraphQL in general, but we don't support anything besides abstract -> concrete type refinements via asConcreteType fields, so we can generate a discriminated union here.

[rbalicki2]

looks great! Only the plural thing seems like a blocker.

[rbalicki2]

1. not a blocker if it's not trivial to fix, but
2. we should confirm that if this isn't provided, we don't suspend. If we write store.picture_together = data.picture_together, we would write undefined, at which point this would cause us to suspend

export function readScalarFieldData(
  field: ReaderScalarField,
  storeRecord: StoreRecord,
  root: StoreLink,
  variables: Variables,
): ReadDataResult<
  string | number | boolean | StoreLink | DataTypeValue[] | null
> {
  const storeRecordName = getParentRecordKey(field, variables);
  const value = storeRecord[storeRecordName];
  // TODO consider making scalars into discriminated unions. This probably has
  // to happen for when we handle errors.
  if (value === undefined) {
    return {
      kind: 'MissingData',
      reason: 'No value for ' + storeRecordName + ' on root ' + root.__link,
      recordLink: root,
    };
  }
  return { kind: 'Success', data: value };
}

3. if it does cause us to suspend, I will inform Jerred about this, and he can use Isograph with that issue until we fix it

[rbalicki2]

🤔 can we make this a union of concrete strings of types that implement Actor? Not a blocker

[rbalicki2]

this should be an array

[rbalicki2]

shipitttt