Skip to content

add __typename to unions #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2025
Merged

add __typename to unions #765

merged 1 commit into from
Nov 21, 2025

Conversation

@PatrykWalach
Copy link
Member

@PatrykWalach PatrykWalach commented Nov 21, 2025 •
edited
Loading

This was referenced Nov 21, 2025
Merged
Closed
rbalicki2
rbalicki2 reviewed Nov 21, 2025
View reviewed changes
crates/graphql_network_protocol/src/process_type_system_definition.rs
match self {
GraphQLObjectDefinitionType::InputObject => false,
GraphQLObjectDefinitionType::Union => false,
GraphQLObjectDefinitionType::Union => true,
Copy link
Collaborator

@rbalicki2 rbalicki2 Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@rbalicki2 rbalicki2 merged commit e1250c0 into isographlabs:main Nov 21, 2025
23 of 24 checks passed
@rbalicki2 rbalicki2 deleted the p-branch-23 branch November 21, 2025 23:54
@PatrykWalach PatrykWalach restored the p-branch-23 branch November 22, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rbalicki2 rbalicki2 rbalicki2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

__typename field doesn't exist on unions

2 participants

@PatrykWalach @rbalicki2