-
Notifications
You must be signed in to change notification settings - Fork 44
Update gitlab-api dependency #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Due to the breaking changes in the transition from GitLab API 5.8.x to GitLab API 6.x, we need to plan a coordinated release of this pull request and other pull requests:
If a user installs the new release of GitLab API plugin that includes GitLab API 6.x, without updating any of the other installed plugins, those installed plugins will likely be broken and report errors. I will be out of the office from Oct 27 - Nov 7, so won't be able to help coordinate the release of those plugins until after I return. Maintainers of those plugins need to all agree that they will release a new version soon after the release of this pull request. |
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
MarkEWaite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to use the released version of the GitLab API 6.2.0 plugin
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
MarkEWaite
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this will need to change the Jenkins baseline from 2.492 to 2.504 and will need to update the plugin BOM version to 5659.vecf9e2dc5a_ed. It can also remove the version declaration for jakarta-xml-bind-api and jackson2-api once the BOM version is updated.
Would you like me to do that @MarkEWaite? |
Since we haven't seen anything from @zbynek yet, I think that it may be best if you do it. If it helps to have a comparison, you can refer to https://github.com/MarkEWaite/gitlab-oauth-plugin/tree/update-deps |
krisstern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks @zbynek for the PR! |
|
@MarkEWaite I am cutting a new release now |
Downstream of jenkinsci/gitlab-api-plugin#121 -- changes some inports to fit the new API.
See also https://issues.jenkins.io/browse/JENKINS-76091
Testing done
Checked that together with the upstream PR and a hack to add
jersey3-apidependency to that plugin this resolves the issue of authentication not working with Jackson plugin v 2.20.0.Submitter checklist