Skip to content

Conversation

@zbynek
Copy link
Contributor

@zbynek zbynek commented Sep 14, 2025

Downstream of jenkinsci/gitlab-api-plugin#121 -- changes some inports to fit the new API.

See also https://issues.jenkins.io/browse/JENKINS-76091

Testing done

Checked that together with the upstream PR and a hack to add jersey3-api dependency to that plugin this resolves the issue of authentication not working with Jackson plugin v 2.20.0.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • [n/a] Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@zbynek zbynek requested a review from a team as a code owner September 14, 2025 13:23
@zbynek zbynek marked this pull request as draft September 14, 2025 22:19
@MarkEWaite
Copy link
Contributor

Due to the breaking changes in the transition from GitLab API 5.8.x to GitLab API 6.x, we need to plan a coordinated release of this pull request and other pull requests:

If a user installs the new release of GitLab API plugin that includes GitLab API 6.x, without updating any of the other installed plugins, those installed plugins will likely be broken and report errors.

I will be out of the office from Oct 27 - Nov 7, so won't be able to help coordinate the release of those plugins until after I return. Maintainers of those plugins need to all agree that they will release a new version soon after the release of this pull request.

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to use the released version of the GitLab API 6.2.0 plugin

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this will need to change the Jenkins baseline from 2.492 to 2.504 and will need to update the plugin BOM version to 5659.vecf9e2dc5a_ed. It can also remove the version declaration for jakarta-xml-bind-api and jackson2-api once the BOM version is updated.

@krisstern
Copy link
Member

I believe this will need to change the Jenkins baseline from 2.492 to 2.504 and will need to update the plugin BOM version to 5659.vecf9e2dc5a_ed. It can also remove the version declaration for jakarta-xml-bind-api and jackson2-api once the BOM version is updated.

Would you like me to do that @MarkEWaite?

@MarkEWaite
Copy link
Contributor

I believe this will need to change the Jenkins baseline from 2.492 to 2.504 and will need to update the plugin BOM version to 5659.vecf9e2dc5a_ed. It can also remove the version declaration for jakarta-xml-bind-api and jackson2-api once the BOM version is updated.

Would you like me to do that @MarkEWaite?

Since we haven't seen anything from @zbynek yet, I think that it may be best if you do it. If it helps to have a comparison, you can refer to https://github.com/MarkEWaite/gitlab-oauth-plugin/tree/update-deps

Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krisstern
Copy link
Member

Thanks @zbynek for the PR!

@krisstern krisstern added chore dependencies Pull requests that update a dependency file labels Nov 14, 2025
@krisstern krisstern merged commit a6969e0 into jenkinsci:master Nov 14, 2025
16 checks passed
@krisstern
Copy link
Member

@MarkEWaite I am cutting a new release now

@krisstern
Copy link
Member

Here it is: https://github.com/jenkinsci/gitlab-oauth-plugin/releases/tag/gitlab-oauth-1.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants