-
Notifications
You must be signed in to change notification settings - Fork 106
Migrate gitlab api from 5 to 6 #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate gitlab api from 5 to 6 #511
Conversation
…420.v8a_08b_d57ca_05
|
I was able to use the latest build of the latest commit to build https://gitlab.com/MarkEWaite/hugo-experiment without problem. I used a multibranch pipeline, set GitLab Project source, didn't use any credentials, used |
|
I've tested the incremental build of this pull request with the latest incremental build from: Due to the breaking changes in the transition from GitLab API 5.8.x to GitLab API 6.x, we need to plan a coordinated release of this pull request and other pull requests:
If a user installs the new release of GitLab API plugin that includes GitLab API 6.x, without updating any of the other installed plugins, those installed plugins will likely be broken and report errors. I will be out of the office from Oct 27 - Nov 7, so won't be able to help coordinate the release of those plugins until after I return. Maintainers of those plugins need to all agree that they will release a new version soon after the release of the API plugin pull request. |
Combine multiple plugin pull requests for compatibility testing. Pull requests include: * jenkinsci/gitlab-api-plugin#121 * jenkinsci/gitlab-branch-source-plugin#511 * jenkinsci/gitlab-logo-plugin#131 * jenkinsci/gitlab-oauth-plugin#201
|
@jetersen we would need to schedule a synchronised release of jenkinsci/gitlab-api-plugin#121 and this pull request. Would you be available perform it (no schedule yet, just trying to prepare it)? If not, maybe I can become a temporary maintainer of the plugin to help you with that? cc @MarkEWaite |
I'd like to do the release either this week or next week, but a coordinated release of all the components is much more important than the timing of the release. |
|
@alecharp I am available |
|
The version of GitLab API plugin was bump to 6.2.0-111.vf174d6b_8c12e which is a release containing jenkinsci/gitlab-api-plugin#121. Once this was validated by CI, it should be merged and release as soon as possible. |
|
@alecharp I believe that the bom-2.504.x version needs to be updated to either |
|
Thanks for catching that @MarkEWaite. We are good now. @jetersen if you can have a look that would be fantastic. |
This provides the migration of the GitLab API from version 5 to version 6.
Requires jenkinsci/gitlab-api-plugin#121.
Testing done
Ran
mvn verifylocally without any problem.Submitter checklist