Open
Conversation
This was referenced Nov 13, 2014
|
What about a merge? |
|
How much slower is this now over NSJSONSerializer? |
This was referenced Oct 2, 2015
jcbertin
referenced
this pull request
Oct 11, 2015
…rning. The current (at the time of this writing) version of the `clang` static analyzer is complaing that the `objects` pointer is `NULL`. This is a false positive warning from the analyzer.
|
As apple suggested, we should use public API not to rely on these internal details. https://developer.apple.com/videos/play/wwdc2020/10163/ Advancements in the Objective-C runtime |
Author
|
Added JSONKitTest for benchmarking this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once and for all, JSONKit crash on modern iOS/OSX because it doesn't handle tagged pointers correctly. Thus, when the code try to access ISA pointer directly by dereferencing the object without checking for tagged pointers, it will crash. Period.
This patch handle tagged pointers on both platforms and add 64bit compatibility.
I use it on machines running 24 hours a day for years now on system as old as iOS 4 and OS X 10.6. Without a crash, end of story.