Specify behavior when only slashes or backslashes are passed as filename parameter#120
Draft
Phillip9587 wants to merge 1 commit intojshttp:masterfrom
Draft
Specify behavior when only slashes or backslashes are passed as filename parameter#120Phillip9587 wants to merge 1 commit intojshttp:masterfrom
Phillip9587 wants to merge 1 commit intojshttp:masterfrom
Conversation
Member
I think it's fine and an expected edge-case.
This is the more interesting question. Additionally, should we even |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm opening this PR to discuss how we should handle filenames consisting only of slashes or backslashes. When a filename contains only slashes, the function returns an invalid header in my opinion:
attachment; filename*=UTF-8''Is this the desired behavior, or should we handle it differently? Should we add explicit validation to reject invalid filenames?