Skip to content

Specify behavior when only slashes or backslashes are passed as filename parameter #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Phillip9587 wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Draft

Specify behavior when only slashes or backslashes are passed as filename parameter #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,16 @@ describe('contentDisposition(filename)', function () {
'attachment; filename="plans.pdf"')
})

it('should use the basename of a posix path with only slashes', function () {
assert.strictEqual(contentDisposition('///'),
'attachment; filename*=UTF-8\'\'')
})

it('should use the basename of a windows path with only slashes', function () {
assert.strictEqual(contentDisposition('\\\\\\'),
'attachment; filename*=UTF-8\'\'')
})

describe('when "filename" is US-ASCII', function () {
it('should only include filename parameter', function () {
assert.strictEqual(contentDisposition('plans.pdf'),
Expand Down