interface: add maxConcurrency for StageConfig in UpdateRun #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 28, 2025 17:57
Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
Arvindthiru
force-pushed
the
parallelAPI
branch
from
98aa2a4 to
4e5999d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
weng271190436
previously approved these changes
Oct 29, 2025
britaniar
previously approved these changes
Oct 29, 2025
Signed-off-by: Arvind Thirumurugan <arvindth@microsoft.com>
Arvindthiru
dismissed stale reviews from britaniar and weng271190436
via
267b5c7
ryanzhang-oss
approved these changes
Oct 30, 2025
|
Please provide a clear PR description |
serbrech
reviewed
Nov 3, 2025
serbrech
reviewed
Nov 3, 2025
| "region": "no-exist", | ||
| }, | ||
| }, | ||
| MaxConcurrency: &intstr.IntOrString{ |
There was a problem hiding this comment.
should there be an integration test for the percentage case?
Collaborator
Author
There was a problem hiding this comment.
Added these changes to fix failing ITs, since MaxConcurrency defaults to 1. Will add more tests when implementing the API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer