-
Notifications
You must be signed in to change notification settings - Fork 19
interface: add maxConcurrency for StageConfig in UpdateRun #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,6 +29,7 @@ import ( | |
| "k8s.io/apimachinery/pkg/api/meta" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| "k8s.io/apimachinery/pkg/util/intstr" | ||
|
|
||
| clusterv1beta1 "github.com/kubefleet-dev/kubefleet/apis/cluster/v1beta1" | ||
| placementv1beta1 "github.com/kubefleet-dev/kubefleet/apis/placement/v1beta1" | ||
|
|
@@ -303,6 +304,10 @@ var _ = Describe("UpdateRun validation tests", func() { | |
| "region": "no-exist", | ||
| }, | ||
| }, | ||
| MaxConcurrency: &intstr.IntOrString{ | ||
| Type: intstr.Int, | ||
| IntVal: 1, | ||
| }, | ||
| }) | ||
| Expect(k8sClient.Status().Update(ctx, updateRun)).Should(Succeed()) | ||
|
|
||
|
|
@@ -316,6 +321,10 @@ var _ = Describe("UpdateRun validation tests", func() { | |
| "region": "no-exist", | ||
| }, | ||
| }, | ||
| MaxConcurrency: &intstr.IntOrString{ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should there be an integration test for the percentage case?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added these changes to fix failing ITs, since MaxConcurrency defaults to 1. Will add more tests when implementing the API |
||
| Type: intstr.Int, | ||
| IntVal: 1, | ||
| }, | ||
| }) | ||
| validateClusterStagedUpdateRunStatus(ctx, updateRun, wantStatus, "the number of stages in the updateRun has changed") | ||
| }) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.