-
Notifications
You must be signed in to change notification settings - Fork 4.3k
ci: dedicated UT jobs for CA and VPA #8669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
k8s-ci-robot
merged 4 commits into
kubernetes:master
from
jackfrancis:ci-split-test-verify
Oct 31, 2025
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| name: Cluster Autoscaler | ||
|
|
||
| on: | ||
| push: | ||
| paths: | ||
| - 'cluster-autoscaler/**' | ||
| pull_request: | ||
| paths: | ||
| - 'cluster-autoscaler/**' | ||
|
|
||
| env: | ||
| GOPATH: ${{ github.workspace }}/go | ||
|
|
||
| permissions: | ||
| contents: read | ||
| checks: write | ||
|
|
||
| jobs: | ||
| test: | ||
| name: Run unit tests | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4.2.2 | ||
| with: | ||
| path: ${{ env.GOPATH }}/src/k8s.io/autoscaler | ||
|
|
||
| - name: Set up Go | ||
| uses: actions/setup-go@v5.5.0 | ||
| with: | ||
| go-version: '1.24.0' | ||
| cache-dependency-path: | | ||
| ${{ env.GOPATH}}/src/k8s.io/autoscaler/cluster-autoscaler/go.sum | ||
|
|
||
| - name: Apt-get | ||
| run: sudo apt-get install libseccomp-dev -qq | ||
|
|
||
| - name: Test | ||
| working-directory: ${{ env.GOPATH }}/src/k8s.io/autoscaler | ||
| run: hack/for-go-proj.sh cluster-autoscaler | ||
| env: | ||
| GO111MODULE: auto | ||
| PROJECT_NAMES: "" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| name: Vertical Pod Autoscaler | ||
|
|
||
| on: | ||
| push: | ||
| paths: | ||
| - 'vertical-pod-autoscaler/**' | ||
| pull_request: | ||
| paths: | ||
| - 'vertical-pod-autoscaler/**' | ||
|
|
||
| env: | ||
| GOPATH: ${{ github.workspace }}/go | ||
|
|
||
| permissions: | ||
| contents: read | ||
| checks: write | ||
|
|
||
| jobs: | ||
| test: | ||
| name: Run unit tests | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4.2.2 | ||
| with: | ||
| path: ${{ env.GOPATH }}/src/k8s.io/autoscaler | ||
|
|
||
| - name: Set up Go | ||
| uses: actions/setup-go@v5.5.0 | ||
| with: | ||
| go-version: '1.24.0' | ||
| cache-dependency-path: | | ||
| ${{ env.GOPATH}}/src/k8s.io/autoscaler/vertical-pod-autoscaler/go.sum | ||
| ${{ env.GOPATH}}/src/k8s.io/autoscaler/vertical-pod-autoscaler/e2e/go.sum | ||
|
|
||
| - name: Apt-get | ||
| run: sudo apt-get install libseccomp-dev -qq | ||
|
|
||
| - name: Test | ||
| working-directory: ${{ env.GOPATH }}/src/k8s.io/autoscaler | ||
| run: hack/for-go-proj.sh vertical-pod-autoscaler | ||
| env: | ||
| GO111MODULE: auto | ||
| PROJECT_NAMES: "" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the logic is slightly different for each project anyway, I wonder if we should go a step further and just have a per-project file instead of keeping a single entry point here? If not, could we at least rename this file to something more accurate (e.g.
run-unit-tests.sh)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with per-project files
These projects aren't really related at all, and only just share a repo.
Having to maintain the logic of handling multiple projects is sometimes annoying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree on that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do this in a follow-up PR so the changes can be more discrete to eval and potentially roll back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#8755