Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions .github/workflows/ca-test.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
name: Cluster Autoscaler

on:
push:
paths:
- 'cluster-autoscaler/**'
pull_request:
paths:
- 'cluster-autoscaler/**'

env:
GOPATH: ${{ github.workspace }}/go

permissions:
contents: read
checks: write

jobs:
test:
name: Run unit tests
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4.2.2
with:
path: ${{ env.GOPATH }}/src/k8s.io/autoscaler

- name: Set up Go
uses: actions/setup-go@v5.5.0
with:
go-version: '1.24.0'
cache-dependency-path: |
${{ env.GOPATH}}/src/k8s.io/autoscaler/cluster-autoscaler/go.sum

- name: Apt-get
run: sudo apt-get install libseccomp-dev -qq

- name: Test
working-directory: ${{ env.GOPATH }}/src/k8s.io/autoscaler
run: hack/for-go-proj.sh cluster-autoscaler
env:
GO111MODULE: auto
PROJECT_NAMES: ""
10 changes: 2 additions & 8 deletions .github/workflows/ci.yaml → .github/workflows/verify.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Tests
name: Verify Go

on:
- push
Expand All @@ -12,7 +12,7 @@ permissions:
checks: write

jobs:
test-and-verify:
verify:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4.2.2
Expand Down Expand Up @@ -42,9 +42,3 @@ jobs:
run: hack/verify-all.sh -v
env:
GO111MODULE: auto

- name: Test
working-directory: ${{ env.GOPATH }}/src/k8s.io/autoscaler
run: hack/for-go-proj.sh test
env:
GO111MODULE: auto
6 changes: 3 additions & 3 deletions .github/workflows/vpa-golangci-lint.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Lint
name: Vertical Pod Autoscaler

on:
push:
Expand All @@ -15,8 +15,8 @@ permissions:
contents: read

jobs:
golangci:
name: golangci-lint - VPA
lint:
name: Run golangci-lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5
Expand Down
43 changes: 43 additions & 0 deletions .github/workflows/vpa-test.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: Vertical Pod Autoscaler

on:
push:
paths:
- 'vertical-pod-autoscaler/**'
pull_request:
paths:
- 'vertical-pod-autoscaler/**'

env:
GOPATH: ${{ github.workspace }}/go

permissions:
contents: read
checks: write

jobs:
test:
name: Run unit tests
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4.2.2
with:
path: ${{ env.GOPATH }}/src/k8s.io/autoscaler

- name: Set up Go
uses: actions/setup-go@v5.5.0
with:
go-version: '1.24.0'
cache-dependency-path: |
${{ env.GOPATH}}/src/k8s.io/autoscaler/vertical-pod-autoscaler/go.sum
${{ env.GOPATH}}/src/k8s.io/autoscaler/vertical-pod-autoscaler/e2e/go.sum

- name: Apt-get
run: sudo apt-get install libseccomp-dev -qq

- name: Test
working-directory: ${{ env.GOPATH }}/src/k8s.io/autoscaler
run: hack/for-go-proj.sh vertical-pod-autoscaler
env:
GO111MODULE: auto
PROJECT_NAMES: ""
2 changes: 1 addition & 1 deletion cluster-autoscaler/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# Introduction

Cluster Autoscaler is a tool that automatically adjusts the size of the Kubernetes cluster when one of the following conditions is true:
* there are pods that failed to run in the cluster due to insufficient
* there are pods that failed to be scheduled in the cluster due to insufficient
resources.
* there are nodes in the cluster that have been underutilized for an extended period of time and their pods can be placed on other existing nodes.

Expand Down
65 changes: 23 additions & 42 deletions hack/for-go-proj.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,58 +19,39 @@ set -o pipefail
set -o nounset

CONTRIB_ROOT="$(dirname ${BASH_SOURCE})/.."
PROJECT_NAMES=(addon-resizer vertical-pod-autoscaler)

if [[ $# -ne 1 ]]; then
echo "missing subcommand: [build|install|test]"
echo "missing subcommand: [cluster-autoscaler|vertical-pod-autoscaler|addon-resizer]"
exit 1
fi

CMD="${1}"

case "${CMD}" in
"build")
PROJECT="${1}"

case "${PROJECT}" in
Copy link
Collaborator

@towca towca Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the logic is slightly different for each project anyway, I wonder if we should go a step further and just have a per-project file instead of keeping a single entry point here? If not, could we at least rename this file to something more accurate (e.g. run-unit-tests.sh)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with per-project files
These projects aren't really related at all, and only just share a repo.
Having to maintain the logic of handling multiple projects is sometimes annoying

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree on that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do this in a follow-up PR so the changes can be more discrete to eval and potentially roll back

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"cluster-autoscaler")
pushd ${CONTRIB_ROOT}/cluster-autoscaler/
# TODO: #8127 - Use default analyzers set by `go test` to include `printf` analyzer.
# Default analyzers that go test runs according to https://github.com/golang/go/blob/52624e533fe52329da5ba6ebb9c37712048168e0/src/cmd/go/internal/test/test.go#L649
# This doesn't include the `printf` analyzer until cluster-autoscaler libraries are updated.
ANALYZERS="atomic,bool,buildtags,directive,errorsas,ifaceassert,nilfunc,slog,stringintconv,tests"
go test -count=1 ./... -vet="${ANALYZERS}"
popd
;;
"install")
"vertical-pod-autoscaler")
pushd ${CONTRIB_ROOT}/vertical-pod-autoscaler
go test -count=1 -race $(go list ./... | grep -v /vendor/ | grep -v vertical-pod-autoscaler/e2e | grep -v cluster-autoscaler/apis)
popd
pushd ${CONTRIB_ROOT}/vertical-pod-autoscaler/e2e
go test -run=None ./...
popd
;;
"test")
"addon-resizer")
pushd ${CONTRIB_ROOT}/addon-resizer
godep go test -race $(go list ./... | grep -v /vendor/ | grep -v vertical-pod-autoscaler/e2e)
popd
;;
*)
echo "invalid subcommand: ${CMD}"
exit 1
;;
esac

for project_name in ${PROJECT_NAMES[*]}; do
(
export GO111MODULE=auto
project=${CONTRIB_ROOT}/${project_name}
echo "${CMD}ing ${project}"
cd "${project}"
case "${CMD}" in
"test")
if [[ -n $(find . -name "Godeps.json") ]]; then
godep go test -race $(go list ./... | grep -v /vendor/ | grep -v vertical-pod-autoscaler/e2e)
else
go test -count=1 -race $(go list ./... | grep -v /vendor/ | grep -v vertical-pod-autoscaler/e2e | grep -v cluster-autoscaler/apis)
fi
;;
*)
godep go "${CMD}" ./...
;;
esac
)
done;

if [ "${CMD}" = "build" ] || [ "${CMD}" == "test" ]; then
pushd ${CONTRIB_ROOT}/vertical-pod-autoscaler/e2e
go test -run=None ./...
popd
pushd ${CONTRIB_ROOT}/cluster-autoscaler/
# TODO: #8127 - Use default analyzers set by `go test` to include `printf` analyzer.
# Default analyzers that go test runs according to https://github.com/golang/go/blob/52624e533fe52329da5ba6ebb9c37712048168e0/src/cmd/go/internal/test/test.go#L649
# This doesn't include the `printf` analyzer until cluster-autoscaler libraries are updated.
ANALYZERS="atomic,bool,buildtags,directive,errorsas,ifaceassert,nilfunc,slog,stringintconv,tests"
go test -count=1 ./... -vet="${ANALYZERS}"
popd
fi
2 changes: 1 addition & 1 deletion vertical-pod-autoscaler/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
Vertical Pod Autoscaler (VPA) frees users from the necessity of setting
up-to-date resource requests for the containers in their pods. When
configured, it will set the requests automatically based on usage and thus
allow proper scheduling onto nodes so that appropriate resource amount is
allow proper scheduling onto nodes so that appropriate resource overhead is
available for each pod. It will also maintain ratios between requests and
limits that were specified in initial containers configuration.

Expand Down
Loading