fix: remove hardcoded host.docker.internal default for DOCLING_SERVE_URL#1186
Open
Jah-yee wants to merge 1 commit intolangflow-ai:mainfrom
Open
fix: remove hardcoded host.docker.internal default for DOCLING_SERVE_URL#1186Jah-yee wants to merge 1 commit intolangflow-ai:mainfrom
Jah-yee wants to merge 1 commit intolangflow-ai:mainfrom
Conversation
The hardcoded default 'http://host.docker.internal:5001' prevents the container-aware auto-detection logic in docling.py from running. This causes failures in pure WSL2 Docker environments where host.docker.internal doesn't resolve. Now DOCLING_SERVE_URL defaults to empty, allowing determine_docling_host() to auto-detect the correct host based on the environment (Docker Desktop, WSL2, containers, etc.). Users can still override with environment variable. Fixes langflow-ai#1178
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The hardcoded default
http://host.docker.internal:5001prevents the container-aware auto-detection logic indocling.pyfrom running. This causes failures in pure WSL2 Docker environments wherehost.docker.internaldoesn't resolve.Problem
When running
uvx openragin a pure WSL2 environment with native Docker engine:docker-compose.ymlsetsDOCLING_SERVE_URL=http://host.docker.internal:5001as the defaulthost.docker.internaldetermine_docling_host()function (which handles WSL via gateway IP fallback) is never called because the env var override takes precedenceFix
Now
DOCLING_SERVE_URLdefaults to empty, allowingdetermine_docling_host()to auto-detect the correct host based on the environment (Docker Desktop, WSL2, containers, etc.). Users can still override with environment variable.Fixes #1178