QOL fixes to Makefile (relative file calling and test.tfvars handling) #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling the tfmodule/lint function I kept getting errors based on the sym link placement and this function relative to the directory I was running from. Instead this should handle the relative nature of the directories a little more naturally. Signed-off-by: jaxom-widby-nttd <jaxom.widby@nttdata.com>
Update Makefile fallback handling of plan_terraform_module variable call. Previously this required that there was a file defined within this variable context that is different than the default value for the parameter. This update checks for the existence of that file ahead of run, if it does exist it will honor it else leave it out. Signed-off-by: jaxom-widby-nttd <jaxom.widby@nttdata.com>
jaxom-widby-nttd
changed the title
ben-vaughan-nttd
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running through some of the testing/migrating over a repo to utilize this I ran across a couple of small callouts that took me a bit off track:
When running tfmodule/lint I was getting errors as the tflint call had 2 assumed locations for the .tflint config file. Other scripting places this within the directory for the repo however either I am at a different depth than expected or there is some handler with the devcontainer that didnt work as expected. Simplifying the call for this the update simply makes it attempt to run from the relative called directory.
plan_terraform_module was attempting to use a test.tfvars file that wasnt present in the examples directories I was working with (which did have terraform.tfvars). Slight update to have an existence check ahead of utilizing the customized variable with fallback to default. (also outputs to console for debugging).