Skip to content

QOL fixes to Makefile (relative file calling and test.tfvars handling) #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

QOL fixes to Makefile (relative file calling and test.tfvars handling) #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
947fbf2
Update makefile to handle relative call location for file placement.
jaxom-widby-nttd Nov 4, 2025
3495764
Update Makefile fallback handling of plan_terraform_module variable call
jaxom-widby-nttd Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tasks/modules/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,15 +98,21 @@ endef

define plan_terraform_module
echo && echo "Planning $(1) ...";
$(TERRAFORM) -chdir=$(1) plan -input=false -out=terraform.tfplan -var-file $(VAR_FILE);
if [ -f "$(1)/$(VAR_FILE)" ]; then \
echo "Using $(VAR_FILE) for variable inputs"; \
$(TERRAFORM) -chdir=$(1) plan -input=false -out=terraform.tfplan -var-file $(VAR_FILE); \
else \
echo "$(VAR_FILE) doesn't exist, falling back to default (terraform.tfvars)"; \
$(TERRAFORM) -chdir=$(1) plan -input=false -out=terraform.tfplan; \
fi;
echo && echo "Creating JSON plan output for $(1) ...";
cd $(1) && $(TERRAFORM) show -json ./terraform.tfplan > ./terraform.tfplan.json;

endef

define tflint_terraform_module
echo && echo "Linting $(1) ...";
(cd $(1) && TF_LOG=info $(TFLINT) -c $(TFLINT_CONFIG) || TF_LOG=info $(TFLINT) -c ../../$(TFLINT_CONFIG)) || exit 1;
(cd $(1) && TF_LOG=info $(TFLINT) -c $(PWD)/$(TFLINT_CONFIG)) || exit 1;

endef

Expand Down