Skip to content

Remove unnecessary teacher eval call #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

Remove unnecessary teacher eval call #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb31d45
remove unnecessary eval call
ClemensSchwarke Nov 13, 2025
0453372
blank line
ClemensSchwarke Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion rsl_rl/modules/student_teacher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ def __init__(

# Teacher
self.teacher = MLP(num_teacher_obs, num_actions, teacher_hidden_dims, activation)
self.teacher.eval()
print(f"Teacher MLP: {self.teacher}")

# Teacher observation normalization
Expand Down
1 change: 1 addition & 0 deletions rsl_rl/runners/distillation_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ def __init__(self, env: VecEnv, train_cfg: dict, log_dir: str | None = None, dev
def learn(self, num_learning_iterations: int, init_at_random_ep_len: bool = False) -> None:
# Initialize writer
self._prepare_logging_writer()

# Check if teacher is loaded
if not self.alg.policy.loaded_teacher:
raise ValueError("Teacher model parameters not loaded. Please load a teacher model to distill.")
Expand Down